From 70bf213a8ba21e2ef8b040ba78b7e91ccac69441 Mon Sep 17 00:00:00 2001
From: bergware <ronald.vd.berg62@gmail.com>
Date: Mon, 6 Jun 2016 00:17:18 +0200
Subject: [PATCH 1/4] Fixed dropdown list may not open in tabbed view

Also made width consistent with other pages
---
 plugins/dynamix/Eth0.page | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/plugins/dynamix/Eth0.page b/plugins/dynamix/Eth0.page
index d2bcb8642..707399cb5 100644
--- a/plugins/dynamix/Eth0.page
+++ b/plugins/dynamix/Eth0.page
@@ -218,8 +218,15 @@ function exitCode(form,key) {
 $(function() {
   var ctrl = "<span id='wait_eth0' class='status red' style='display:none;font-size:small;font-style:italic'>Please wait... configuring interfaces</span>";
   var form = document.eth0_settings;
-  $('#bond0').dropdownchecklist({emptyText:'None', width:130});
-  $('#bridge0').dropdownchecklist({emptyText:'None', width:130});
+<?if ($tabbed && !$disabled):?>
+  $('#tab1').bind({click:function(){
+    $('#bond0').dropdownchecklist('destroy').dropdownchecklist({emptyText:'None', width:131});
+    $('#bridge0').dropdownchecklist('destroy').dropdownchecklist({emptyText:'None', width:131});
+    checkBondingSettings(form,0);
+  }});
+<?endif;?>
+  $('#bond0').dropdownchecklist({emptyText:'None', width:131});
+  $('#bridge0').dropdownchecklist({emptyText:'None', width:131});
   checkBondingSettings(form,0);
   checkBridgingSettings(form,0);
   checkNetworkAccess(form,'eth0');

From fd04e71fb3465b7394d86a5a2603596b2d749b4d Mon Sep 17 00:00:00 2001
From: bergware <ronald.vd.berg62@gmail.com>
Date: Mon, 6 Jun 2016 00:25:38 +0200
Subject: [PATCH 2/4] Fixed dropdown list may not open in tabbed view [2]

---
 plugins/dynamix/Eth0.page | 1 -
 1 file changed, 1 deletion(-)

diff --git a/plugins/dynamix/Eth0.page b/plugins/dynamix/Eth0.page
index 707399cb5..32e8aac6a 100644
--- a/plugins/dynamix/Eth0.page
+++ b/plugins/dynamix/Eth0.page
@@ -222,7 +222,6 @@ $(function() {
   $('#tab1').bind({click:function(){
     $('#bond0').dropdownchecklist('destroy').dropdownchecklist({emptyText:'None', width:131});
     $('#bridge0').dropdownchecklist('destroy').dropdownchecklist({emptyText:'None', width:131});
-    checkBondingSettings(form,0);
   }});
 <?endif;?>
   $('#bond0').dropdownchecklist({emptyText:'None', width:131});

From b6ab3677e2f47eaca790d1841ccd93a5bb2a8e51 Mon Sep 17 00:00:00 2001
From: bergware <ronald.vd.berg62@gmail.com>
Date: Mon, 6 Jun 2016 08:44:22 +0200
Subject: [PATCH 3/4] Added "eth0 down" detection and notice

Displays a message in the footer when eth0 is down
---
 plugins/dynamix/Eth0.page             |  7 +++++++
 plugins/dynamix/include/CheckPort.php | 18 ++++++++++++++++++
 2 files changed, 25 insertions(+)
 create mode 100644 plugins/dynamix/include/CheckPort.php

diff --git a/plugins/dynamix/Eth0.page b/plugins/dynamix/Eth0.page
index 32e8aac6a..f0b1f6362 100644
--- a/plugins/dynamix/Eth0.page
+++ b/plugins/dynamix/Eth0.page
@@ -215,6 +215,12 @@ function exitCode(form,key) {
     stopEvent = true;
   }
 }
+function checkPort() {
+  $.post('/webGui/include/CheckPort.php',{port:'eth0'},function(text) {
+    showNotice(text);
+    setTimeout(checkPort,15000);
+  });
+}
 $(function() {
   var ctrl = "<span id='wait_eth0' class='status red' style='display:none;font-size:small;font-style:italic'>Please wait... configuring interfaces</span>";
   var form = document.eth0_settings;
@@ -242,6 +248,7 @@ $(function() {
 <?else:?>
   $('div[id=title]').append(ctrl);
 <?endif;?>
+  checkPort();
 });
 </script>
 <form markdown="1" name="eth0_settings" method="POST" action="/update.php" target="progressFrame" onchange="exitCode(this,false)" onsubmit="return prepareSettings(this)">
diff --git a/plugins/dynamix/include/CheckPort.php b/plugins/dynamix/include/CheckPort.php
new file mode 100644
index 000000000..7ef188642
--- /dev/null
+++ b/plugins/dynamix/include/CheckPort.php
@@ -0,0 +1,18 @@
+<?PHP
+/* Copyright 2016, Bergware International.
+ * Copyright 2016, Lime Technology
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License version 2,
+ * as published by the Free Software Foundation.
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ */
+?>
+<?
+$port = $_POST['port'] ?: 'eth0';
+if (exec("ip link show $port|grep -om1 'NO-CARRIER'")) {
+  echo "<b>Interface $port is down. Check cable!</b>";
+}
+?>

From a00bad411c7eb39d310c557b38de6935b256b187 Mon Sep 17 00:00:00 2001
From: bergware <ronald.vd.berg62@gmail.com>
Date: Mon, 6 Jun 2016 11:06:53 +0200
Subject: [PATCH 4/4] Fixed legacy support bonding and bridging

---
 plugins/dynamix/scripts/netconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/dynamix/scripts/netconfig b/plugins/dynamix/scripts/netconfig
index 9147ef91f..09e8e2ce4 100755
--- a/plugins/dynamix/scripts/netconfig
+++ b/plugins/dynamix/scripts/netconfig
@@ -33,7 +33,7 @@ if ($run && file_exists($cfg)) {
     $ifname = ifname($set);
   } else {
     // legacy syntax
-    if ($set=='eth0') $ifname = $old['BRIDGING']=='yes' ? $old['BRNAME'] : ($old['BONDING']=='yes' ? $old['BONDNAME'] : $set);
+    if ($set=='eth0') $ifname = $old['BRIDGING']=='yes' ? ($old['BRNAME'] ?: 'br0') : ($old['BONDING']=='yes' ? ($old['BONDNAME'] ?: 'bond0') : $set);
   }
 }