From 29cbd5c42e167678c744dc94578e1a030a20d1b4 Mon Sep 17 00:00:00 2001
From: Andrew Z <unraidsquid@gmail.com>
Date: Tue, 16 Feb 2021 13:29:01 -0500
Subject: [PATCH 1/6] Diagnostics Improvements

---
 plugins/dynamix/Diagnostics.page     | 43 ++++++++++++++++++----------
 plugins/dynamix/include/Download.php |  2 +-
 plugins/dynamix/scripts/diagnostics  | 29 +++++++++++++++++--
 3 files changed, 55 insertions(+), 19 deletions(-)

diff --git a/plugins/dynamix/Diagnostics.page b/plugins/dynamix/Diagnostics.page
index 31906cc0d..9c9dd4718 100644
--- a/plugins/dynamix/Diagnostics.page
+++ b/plugins/dynamix/Diagnostics.page
@@ -25,29 +25,40 @@ pre>p{margin:0;padding:0}
 </style>
 
 <script>
+var diagnosticsFile = "";
+var diagnostic = new NchanSubscriber('/sub/diagnostic');
+diagnostic.on('message',function(data) {
+  if (data) {
+    if (data == diagnosticsFile.replace("/","")+"FINISHED") {
+      diagnostic.stop();
+      swal.close();
+      location = diagnosticsFile;
+    } else {
+      $("#command").html(data);
+    }
+  }
+});
+
 function zipfile(){
   var tzoffset = (new Date()).getTimezoneOffset() * 60000; //offset in milliseconds
   var localISOTime = (new Date(Date.now() - tzoffset)).toISOString().slice(0, -1);
   return '<?=$zip?>-diagnostics-'+localISOTime.substr(0,16).replace(/[-:]/g,'').replace('T','-')+'.zip';
 }
-function cleanUp(file) {
-  if (document.hasFocus()) {
-    $('input[value="Downloading..."]').val('Download').prop('disabled',false);
-    $('div.spinner').hide('slow');
-    $('#pleaseWait').hide('slow');
-    $.post('/webGui/include/Download.php',{cmd:'delete',file:file});
-  } else {
-    setTimeout(function(){cleanUp(file);},2000);
-  }
-}
+
 function diagnostics(file) {
-  $('input[value="Download"]').val('Downloading...').prop('disabled',true);
-  $('div.spinner').show('slow');
-  $('#pleaseWait').show('slow');
   var anonymize = $('#anonymize').is(':checked') ? '' : '-a';
   $.post('/webGui/include/Download.php',{cmd:'diag',file:file,anonymize:anonymize},function(zip) {
-    location = zip;
-    setTimeout(function(){cleanUp(file);},4000);
+    diagnosticsFile = zip;
+    diagnostic.start();
+    swal({
+      title: "_(Downloading...)_",
+      text: "/boot/logs"+zip+"<br><tt><span id='command'></span></tt>",
+      allowOutsideClick: false,
+      showConfirmButton: false,
+      showCancelButton: false,
+      type: "info",
+      html: true
+    });
   });
 }
 </script>
@@ -94,3 +105,5 @@ to the system log.*
 :end
 
 <input type="button" value="_(Download)_" onclick="diagnostics(zipfile())"><input type="button" value="_(Done)_" onclick="done()"><input type="checkbox" id="anonymize" checked>_(Anonymize diagnostics)_
+
+
diff --git a/plugins/dynamix/include/Download.php b/plugins/dynamix/include/Download.php
index a43bcfe15..df6816aa5 100644
--- a/plugins/dynamix/include/Download.php
+++ b/plugins/dynamix/include/Download.php
@@ -34,7 +34,7 @@ case 'delete':
 case 'diag':
   if (is_file("$docroot/$file") && strpos(realpath("$docroot/$file"), $docroot.'/') !== 0) exit;
   $anon = empty($_POST['anonymize']) ? '' : escapeshellarg($_POST['anonymize']);
-  exec("$docroot/webGui/scripts/diagnostics $anon ".escapeshellarg("$docroot/$file"));
+  exec("echo $docroot/webGui/scripts/diagnostics $anon ".escapeshellarg("$docroot/$file")." | at NOW -m > /dev/null 2>&1");
   echo "/$file";
   break;
 case 'unlink':
diff --git a/plugins/dynamix/scripts/diagnostics b/plugins/dynamix/scripts/diagnostics
index 33111f5f7..442f3ea03 100755
--- a/plugins/dynamix/scripts/diagnostics
+++ b/plugins/dynamix/scripts/diagnostics
@@ -1,7 +1,7 @@
 #!/usr/bin/php -q
 <?PHP
-/* Copyright 2005-2021, Lime Technology
- * Copyright 2012-2021, Bergware International.
+/* Copyright 2005-2019, Lime Technology
+ * Copyright 2012-2019, Bergware International.
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License version 2,
@@ -22,11 +22,29 @@ $var = (array)@parse_ini_file("$get/var.ini");
 $docroot = $docroot ?? $_SERVER['DOCUMENT_ROOT'] ?: '/usr/local/emhttp';
 $folders = ['/boot','/boot/config','/boot/config/plugins','/boot/extra','/boot/syslinux','/var/log','/var/log/plugins','/var/log/packages','/tmp'];
 
+function curl_socket($socket, $url, $postdata = NULL) {
+  $ch = curl_init($url);
+  curl_setopt($ch, CURLOPT_UNIX_SOCKET_PATH, $socket);
+  if ($postdata !== NULL) {
+    curl_setopt($ch, CURLOPT_POST, 1);
+    curl_setopt($ch, CURLOPT_POSTFIELDS, $postdata);
+  }
+  curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
+  curl_exec($ch);
+  curl_close($ch);
+}
+function publish($endpoint, $message){
+  curl_socket("/var/run/nginx.socket", "http://localhost/pub/$endpoint?buffer_length=1", $message);
+}
+
 function exert($cmd, &$save=null) {
+  global $cli,$diag;
 // execute command with timeout of 30s
+  publish("diagnostic",$cmd);
   exec("timeout -s9 30 $cmd", $save);
   return implode("\n",$save);
 }
+
 function shareDisks($share) {
   return exec("shopt -s dotglob; getfattr --no-dereference --absolute-names --only-values -n system.LOCATIONS ".escapeshellarg("/usr/local/emhttp/mnt/user/$share")." 2>/dev/null") ?: "no drives";
 }
@@ -301,5 +319,10 @@ if (file_exists($vfiopci)) {
 }
 // create resulting zip file and remove temp folder
 exert("zip -qmr ".escapeshellarg($zip)." ".escapeshellarg("/$diag"));
-if ($cli) echo "done.\nZIP file '$zip' created.\n";
+if ($cli) {
+  echo "done.\nZIP file '$zip' created.\n";
+} else {
+  copy($zip,"/boot/logs/".basename($zip));
+}
+publish("diagnostic",basename($zip)."FINISHED");
 ?>

From a8be22064d5c3a6de530814a4bacdd256144e4a8 Mon Sep 17 00:00:00 2001
From: Andrew Z <unraidsquid@gmail.com>
Date: Tue, 16 Feb 2021 13:48:33 -0500
Subject: [PATCH 2/6] Update Copyright

---
 plugins/dynamix/Diagnostics.page     | 4 ++--
 plugins/dynamix/include/Download.php | 4 ++--
 plugins/dynamix/scripts/diagnostics  | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/plugins/dynamix/Diagnostics.page b/plugins/dynamix/Diagnostics.page
index 9c9dd4718..aaa1a4424 100644
--- a/plugins/dynamix/Diagnostics.page
+++ b/plugins/dynamix/Diagnostics.page
@@ -4,8 +4,8 @@ Icon="icon-diagnostics"
 Tag="tv"
 ---
 <?PHP
-/* Copyright 2005-2020, Lime Technology
- * Copyright 2012-2020, Bergware International.
+/* Copyright 2005-2021, Lime Technology
+ * Copyright 2012-2021, Bergware International.
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License version 2,
diff --git a/plugins/dynamix/include/Download.php b/plugins/dynamix/include/Download.php
index df6816aa5..65624f3b4 100644
--- a/plugins/dynamix/include/Download.php
+++ b/plugins/dynamix/include/Download.php
@@ -1,6 +1,6 @@
 <?PHP
-/* Copyright 2005-2020, Lime Technology
- * Copyright 2012-2020, Bergware International.
+/* Copyright 2005-2021, Lime Technology
+ * Copyright 2012-2021, Bergware International.
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License version 2,
diff --git a/plugins/dynamix/scripts/diagnostics b/plugins/dynamix/scripts/diagnostics
index 442f3ea03..80885ce94 100755
--- a/plugins/dynamix/scripts/diagnostics
+++ b/plugins/dynamix/scripts/diagnostics
@@ -1,7 +1,7 @@
 #!/usr/bin/php -q
 <?PHP
-/* Copyright 2005-2019, Lime Technology
- * Copyright 2012-2019, Bergware International.
+/* Copyright 2005-2021, Lime Technology
+ * Copyright 2012-2021, Bergware International.
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License version 2,

From 1f97918eddcaae401e5e0a52b07773b10b6416a0 Mon Sep 17 00:00:00 2001
From: Andrew Z <unraidsquid@gmail.com>
Date: Tue, 16 Feb 2021 14:04:08 -0500
Subject: [PATCH 3/6] Remove temp file

---
 plugins/dynamix/Diagnostics.page | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/plugins/dynamix/Diagnostics.page b/plugins/dynamix/Diagnostics.page
index aaa1a4424..c97263e96 100644
--- a/plugins/dynamix/Diagnostics.page
+++ b/plugins/dynamix/Diagnostics.page
@@ -26,6 +26,7 @@ pre>p{margin:0;padding:0}
 
 <script>
 var diagnosticsFile = "";
+var file = "";
 var diagnostic = new NchanSubscriber('/sub/diagnostic');
 diagnostic.on('message',function(data) {
   if (data) {
@@ -33,12 +34,21 @@ diagnostic.on('message',function(data) {
       diagnostic.stop();
       swal.close();
       location = diagnosticsFile;
+      setTimeout(function(){cleanUp(file);},4000);
     } else {
       $("#command").html(data);
     }
   }
 });
 
+function cleanUp(file) {	
+  if (document.hasFocus()) {	
+    $.post('/webGui/include/Download.php',{cmd:'delete',file:file});	
+  } else {	
+    setTimeout(function(){cleanUp(file);},2000);	
+  }	
+}
+
 function zipfile(){
   var tzoffset = (new Date()).getTimezoneOffset() * 60000; //offset in milliseconds
   var localISOTime = (new Date(Date.now() - tzoffset)).toISOString().slice(0, -1);

From d8180281950c77fd4e4157e5d3eed1d19d2b1a84 Mon Sep 17 00:00:00 2001
From: Squidly271 <unraidsquid@gmail.com>
Date: Tue, 16 Feb 2021 14:27:24 -0500
Subject: [PATCH 4/6] Fix spurious email

---
 plugins/dynamix/include/Download.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/dynamix/include/Download.php b/plugins/dynamix/include/Download.php
index 65624f3b4..abac1e1e0 100644
--- a/plugins/dynamix/include/Download.php
+++ b/plugins/dynamix/include/Download.php
@@ -34,7 +34,7 @@ case 'delete':
 case 'diag':
   if (is_file("$docroot/$file") && strpos(realpath("$docroot/$file"), $docroot.'/') !== 0) exit;
   $anon = empty($_POST['anonymize']) ? '' : escapeshellarg($_POST['anonymize']);
-  exec("echo $docroot/webGui/scripts/diagnostics $anon ".escapeshellarg("$docroot/$file")." | at NOW -m > /dev/null 2>&1");
+  exec("echo $docroot/webGui/scripts/diagnostics $anon ".escapeshellarg("$docroot/$file")." | at NOW > /dev/null 2>&1");
   echo "/$file";
   break;
 case 'unlink':

From a18530e5aad8251d04cd328eeeeef3fcc5c72dc0 Mon Sep 17 00:00:00 2001
From: ljm42 <larry_meaney@iname.com>
Date: Tue, 16 Feb 2021 17:46:52 -0800
Subject: [PATCH 5/6] SysDevs - fix warn if leave page without saving

---
 plugins/dynamix/SysDevs.page | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/dynamix/SysDevs.page b/plugins/dynamix/SysDevs.page
index 0e55d10d0..07f6c5189 100644
--- a/plugins/dynamix/SysDevs.page
+++ b/plugins/dynamix/SysDevs.page
@@ -24,7 +24,7 @@ table tr td.thin{line-height:8px;height:8px}
 <script>
 $(window).bind('beforeunload',function(e){
   // warn user if they leave the page with unsaved changes
-  if (!$('#applycfg').prop('disabled')) return "You have unsaved changes";
+  if ($('#applycfg') && $('#applycfg').is(":visible") && !$('#applycfg').prop('disabled')) return "You have unsaved changes";
 });
 $(function(){
   $('#t1').load('/webGui/include/SysDevs.php',{table:'t1'});

From 994a60a7d3639fda41c82e0f1c6bdf0636fb732a Mon Sep 17 00:00:00 2001
From: Eric Schultz <eric@startuperic.com>
Date: Wed, 17 Feb 2021 02:03:24 -0600
Subject: [PATCH 6/6] Fix: properly set samesite cookie
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Logging in with Safari works again 🥞
---
 plugins/dynamix/include/local_prepend.php | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/plugins/dynamix/include/local_prepend.php b/plugins/dynamix/include/local_prepend.php
index 20a9c20a2..3cf4f2555 100644
--- a/plugins/dynamix/include/local_prepend.php
+++ b/plugins/dynamix/include/local_prepend.php
@@ -22,10 +22,11 @@ putenv('PATH=.:/usr/local/sbin:/usr/sbin:/sbin:/usr/local/bin:/usr/bin:/bin');
 chdir('/usr/local/emhttp');
 setlocale(LC_ALL,'en_US.UTF-8');
 date_default_timezone_set(substr(readlink('/etc/localtime-copied-from'),20));
-ini_set("session.use_strict_mode", "1");
-session_name("unraid_".md5(strstr($_SERVER['HTTP_HOST'].':', ':', true)));
 $secure = array_key_exists('HTTPS', $_SERVER);
-session_set_cookie_params(0, '/; samesite='.$secure?'strict':'lax', null, $secure, true);
+ini_set("session.use_strict_mode", "1");
+ini_set("session.cookie_samesite", $secure?'Strict':'Lax');
+session_name("unraid_".md5(strstr($_SERVER['HTTP_HOST'].':', ':', true)));
+session_set_cookie_params(0, '/', null, $secure, true);
 if ($_SERVER['SCRIPT_NAME'] != '/login.php' && $_SERVER['SCRIPT_NAME'] != '/auth_request.php' && isset($_SERVER['REQUEST_METHOD']) && $_SERVER['REQUEST_METHOD'] === 'POST') {
     if (!isset($var)) $var = parse_ini_file('state/var.ini');
     if (!isset($var['csrf_token'])) csrf_terminate("uninitialized");