From 227edb0ccb860f25435f9128658bab9ec86d6d89 Mon Sep 17 00:00:00 2001
From: Squidly271 <azawadzki@arrowgames.com>
Date: Sun, 1 Sep 2019 09:27:14 -0400
Subject: [PATCH] Fixed: edge case of multiple user defined elements open
 simultaneously

---
 plugins/dynamix.plugin.manager/PluginHelpers.page | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/plugins/dynamix.plugin.manager/PluginHelpers.page b/plugins/dynamix.plugin.manager/PluginHelpers.page
index ab2915ab5..eceb9173f 100644
--- a/plugins/dynamix.plugin.manager/PluginHelpers.page
+++ b/plugins/dynamix.plugin.manager/PluginHelpers.page
@@ -23,12 +23,10 @@ a.bannerInfo {cursor:pointer;text-decoration:none;}
 .bannerInfo::before {content:"\f05a";font-family:fontAwesome;color:#e68a00;}
 </style>
 <script>
-var ca_PluginUpdatePLG;
-var ca_PluginUpdateElement;
 
-function ca_hidePluginUpdate(version) {
-	$.cookie(ca_PluginUpdatePLG,version);
-	$(ca_PluginUpdateElement).hide();
+function ca_hidePluginUpdate(plugin,version,element) {
+	$.cookie(plugin,version);
+	$(element).hide();
 }
 
 function ca_pluginUpdateInstall(plugin) {
@@ -43,8 +41,7 @@ function ca_pluginUpdateShowInfo(cmd,title,height,width,load,func,id) {
 }
 
 function caPluginUpdateCheck(plugin,options=[],callback) {
-	ca_PluginUpdatePLG = plugin;
-	pluginFilename = plugin.substr(0, plugin.lastIndexOf("."));
+	var pluginFilename = plugin.substr(0, plugin.lastIndexOf("."));
 	console.time("checkPlugin "+plugin);
 	console.log("checkPlugin  "+plugin);
 	$.post("/plugins/dynamix.plugin.manager/scripts/PluginAPI.php",{action:'checkPlugin',options:{plugin:plugin}},function(caAPIresult) {
@@ -66,10 +63,9 @@ function caPluginUpdateCheck(plugin,options=[],callback) {
 				if ( result.updateAvailable ) {
 					var HTML = "An upgrade to "+name+" is available.  Click <a class='ca_PluginUpdateInstall' onclick='ca_pluginUpdateInstall(&quot;"+plugin+"&quot;);'>here</a> to install version "+result.version+" <i class='ca_pluginUpdateInfo fa fa-info-circle' onclick=ca_pluginUpdateShowInfo('/plugins/dynamix.plugin.manager/include/ShowChanges.php?file=%2Ftmp%2Fplugins%2F"+pluginFilename+".txt','Release&nbsp;Notes',600,900); return false;'></i>";
 					if ( ! options.noDismiss ) {
-						HTML = HTML.concat("<span class='ca_PluginUpdateDismiss'><i class='fa fa-close' onclick='ca_hidePluginUpdate(&quot;"+result.version+"&quot;);'></i>");
+						HTML = HTML.concat("<span class='ca_PluginUpdateDismiss'><i class='fa fa-close' onclick='ca_hidePluginUpdate(&quot;"+plugin+"&quot;,&quot;"+result.version+"&quot;,&quot;"+options.element+"&quot;);'></i>");
 					}
 					result.HTML = HTML;
-					ca_PluginUpdateElement = options.element;
 
 					if ( ! options.dontShow ) {
 						$(options.element).html(HTML);