From d3afd2835f8dc11f7c40ea3c709c56795a396e1c Mon Sep 17 00:00:00 2001 From: Squidly271 Date: Thu, 19 Mar 2020 17:02:19 -0400 Subject: [PATCH 1/2] Fix Banner Warnings Not Dismissing --- plugins/dynamix/include/DefaultPageLayout.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/dynamix/include/DefaultPageLayout.php b/plugins/dynamix/include/DefaultPageLayout.php index 6e535a412..696a3f359 100644 --- a/plugins/dynamix/include/DefaultPageLayout.php +++ b/plugins/dynamix/include/DefaultPageLayout.php @@ -223,9 +223,9 @@ function addBannerWarning(text,warning=true,noDismiss=false) { var cookieText = text.replace(/[^a-z0-9]/gi,''); if ($.cookie(cookieText) == "true") return false; if (warning) text = " "+text; - if (!noDismiss) text = text + ""; if ( bannerWarnings.indexOf(text) < 0 ) { var arrayEntry = bannerWarnings.push("placeholder") - 1; + if (!noDismiss) text = text + ""; bannerWarnings[arrayEntry] = text; } else return bannerWarnings.indexOf(text); From c6ff057c70893d7e9373a39884017a28a2f27d59 Mon Sep 17 00:00:00 2001 From: Squidly271 Date: Thu, 19 Mar 2020 18:14:27 -0400 Subject: [PATCH 2/2] Fix dismissed banners reappearing after session Will be now cross site and will stay dismissed for 1 year. --- plugins/dynamix/include/DefaultPageLayout.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/dynamix/include/DefaultPageLayout.php b/plugins/dynamix/include/DefaultPageLayout.php index 696a3f359..d72004fb0 100644 --- a/plugins/dynamix/include/DefaultPageLayout.php +++ b/plugins/dynamix/include/DefaultPageLayout.php @@ -237,7 +237,7 @@ function addBannerWarning(text,warning=true,noDismiss=false) { } function dismissBannerWarning(entry,cookieText) { - $.cookie(cookieText,"true"); + $.cookie(cookieText,"true",{expires:365,path:'/'}); removeBannerWarning(entry); }