From 92a994dc1f431d57f2093d7f303b5fb86200778c Mon Sep 17 00:00:00 2001 From: Zack Spear Date: Tue, 10 Jun 2025 11:18:58 -0700 Subject: [PATCH 1/3] fix: banner icon placement --- .../plugins/dynamix/styles/default-base.css | 44 ++++++++----------- 1 file changed, 19 insertions(+), 25 deletions(-) diff --git a/emhttp/plugins/dynamix/styles/default-base.css b/emhttp/plugins/dynamix/styles/default-base.css index 9cffe20f9..54ca0bb22 100644 --- a/emhttp/plugins/dynamix/styles/default-base.css +++ b/emhttp/plugins/dynamix/styles/default-base.css @@ -1636,26 +1636,6 @@ label.checkbox input:checked ~ .checkmark { label.checkbox input:disabled ~ .checkmark { opacity: 0.5; } -a.bannerDismiss { - float: right; - cursor: pointer; - text-decoration: none; - margin-right: 1rem; -} -.bannerDismiss::before { - content: "\e92f"; - font-family: Unraid; - color: var(--orange-300); -} -a.bannerInfo { - cursor: pointer; - text-decoration: none; -} -.bannerInfo::before { - content: "\f05a"; - font-family: fontAwesome; - color: var(--orange-300); -} ::-webkit-scrollbar { width: 8px; height: 8px; @@ -1693,10 +1673,6 @@ a.bannerInfo { z-index: 999; box-sizing: border-box; } -/* Add padding to the right so the icon can sit absolutely positioned in the padding */ -.upgrade_notice:has(i) { - padding-right: 3.5rem; -} .upgrade_notice.done { color: var(--green-800); background-color: var(--green-100); @@ -1707,7 +1683,25 @@ a.bannerInfo { background-color: var(--red-300); border-color: var(--red-600); } -.upgrade_notice i { +.bannerDismiss::before { + content: "\e92f"; + font-family: Unraid; + color: var(--orange-300); +} +.bannerInfo { + cursor: pointer; + text-decoration: none; +} +.bannerInfo::before { + content: "\f05a"; + font-family: fontAwesome; + color: var(--orange-300); +} +/* Add padding to the right so the icon can sit absolutely positioned in the padding */ +.upgrade_notice:has(.bannerDismiss) { + padding-right: 3.5rem; +} +.upgrade_notice .bannerDismiss { position: absolute; top: 50%; right: 1rem; From bbd547235c8894d39930a14c9a490e0315457fb7 Mon Sep 17 00:00:00 2001 From: Zack Spear Date: Tue, 10 Jun 2025 14:53:26 -0700 Subject: [PATCH 2/3] refactor: consolidate .ca_element_notice styles into default-base.css - Merged styles from the deleted PluginHelpers.css into default-base.css. - Updated .upgrade_notice and .ca_element_notice styles for consistency. - Added padding to .bannerInfo and adjusted related selectors for improved layout. --- .../sheets/PluginHelpers.css | 30 ------------------- .../plugins/dynamix/styles/default-base.css | 12 ++++++-- 2 files changed, 9 insertions(+), 33 deletions(-) delete mode 100644 emhttp/plugins/dynamix.plugin.manager/sheets/PluginHelpers.css diff --git a/emhttp/plugins/dynamix.plugin.manager/sheets/PluginHelpers.css b/emhttp/plugins/dynamix.plugin.manager/sheets/PluginHelpers.css deleted file mode 100644 index 76ce9e196..000000000 --- a/emhttp/plugins/dynamix.plugin.manager/sheets/PluginHelpers.css +++ /dev/null @@ -1,30 +0,0 @@ -.ca_element_notice { - padding-right: 20px; - width: 100%; - height: 40px; - line-height: 40px; - color: var(--orange-300); - background: var(--yellow-200); - border-bottom: var(--orange-300) 1px solid; - text-align: center; - font-size: 1.4rem; - z-index: 900; -} -a.ca_PluginUpdateInstall { - cursor: pointer; -} -span.ca_PluginUpdateDismiss { - float: right; - margin-right: 20px; - cursor: pointer; -} -span.bannerInfo { - cursor: pointer; - text-decoration: none; - margin: 0 12px 0 6px; -} -span.bannerInfo::before { - content: "\f05a"; - font-family: fontAwesome; - color: var(--orange-300); -} diff --git a/emhttp/plugins/dynamix/styles/default-base.css b/emhttp/plugins/dynamix/styles/default-base.css index 54ca0bb22..3ffa07984 100644 --- a/emhttp/plugins/dynamix/styles/default-base.css +++ b/emhttp/plugins/dynamix/styles/default-base.css @@ -1656,7 +1656,8 @@ label.checkbox input:disabled ~ .checkmark { .inline_help { display: none; } -.upgrade_notice { +.upgrade_notice, +.ca_element_notice { color: var(--black); background-color: var(--yellow-200); border: 1px solid var(--orange-300); @@ -1688,9 +1689,11 @@ label.checkbox input:disabled ~ .checkmark { font-family: Unraid; color: var(--orange-300); } +.ca_PluginUpdateInstall, .bannerInfo { cursor: pointer; text-decoration: none; + padding: 0 .5rem; } .bannerInfo::before { content: "\f05a"; @@ -1698,10 +1701,13 @@ label.checkbox input:disabled ~ .checkmark { color: var(--orange-300); } /* Add padding to the right so the icon can sit absolutely positioned in the padding */ -.upgrade_notice:has(.bannerDismiss) { +.upgrade_notice:has(.bannerDismiss), +.ca_element_notice:has(.ca_PluginUpdateDismiss) { padding-right: 3.5rem; } -.upgrade_notice .bannerDismiss { +.upgrade_notice .bannerDismiss, +.ca_element_notice .bannerDismiss, +.ca_PluginUpdateDismiss { position: absolute; top: 50%; right: 1rem; From 9b79ebf37cfba14e2b9728dd25131eff2ac27b42 Mon Sep 17 00:00:00 2001 From: Zack Spear Date: Tue, 10 Jun 2025 14:56:27 -0700 Subject: [PATCH 3/3] fix: adjust z-index for banner dimiss styling --- emhttp/plugins/dynamix/styles/default-base.css | 1 + 1 file changed, 1 insertion(+) diff --git a/emhttp/plugins/dynamix/styles/default-base.css b/emhttp/plugins/dynamix/styles/default-base.css index 3ffa07984..6310f3318 100644 --- a/emhttp/plugins/dynamix/styles/default-base.css +++ b/emhttp/plugins/dynamix/styles/default-base.css @@ -1713,6 +1713,7 @@ label.checkbox input:disabled ~ .checkmark { right: 1rem; transform: translateY(-50%); cursor: pointer; + z-index: 1; } .back_to_top, .move_to_end {