mirror/webgui
1
0
Fork 0
mirror of https://github.com/unraid/webgui.git synced 2026-01-03 16:14:54 -06:00
Code Issues Packages Projects Releases Wiki Activity

style: enhance form input handling in SMBActiveDirectory.page

Browse Source 
- Updated input value handling to use _var() for better security and consistency.
- Refactored submit button logic to improve user experience by enabling/disabling based on AD join status.
- Cleaned up form layout for better readability and maintainability.
This commit is contained in:
Zack Spear
2025-05-28 15:37:57 -07:00
parent 05c1a1ba8c
commit 5d2e356ea9
1 changed files with 14 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
emhttp/plugins/dynamix/SMBActiveDirectory.page
View File

@@ -15,37 +15,39 @@ Cond="($var['shareSMBEnabled']=='ads')"
* all copies or substantial portions of the Software.
*/
?>
<?php
$adJoined = $var['joinStatus'] == "Joined";
?>
<form markdown="1" name="JoinOps" method="POST" action="/update.htm" target="progressFrame">
_(AD join status)_:
: <?=$var['joinStatus'];?>&nbsp;
_(AD domain name)_ (FQDN):
: <input type="text" name="DOMAIN" maxlength="80" value="<?=htmlspecialchars($var['DOMAIN'])?>">
: <input type="text" name="DOMAIN" maxlength="80" value="<?=htmlspecialchars(_var($var['DOMAIN']))?>">
_(AD short domain name)_:
: <input type="text" name="DOMAIN_SHORT" maxlength="40" value="<?=htmlspecialchars($var['DOMAIN_SHORT'])?>">
: <input type="text" name="DOMAIN_SHORT" maxlength="40" value="<?=htmlspecialchars(_var($var['DOMAIN_SHORT']))?>">
_(AD account login)_:
: <input type="text" name="DOMAIN_LOGIN" maxlength="40" value="<?=htmlspecialchars($var['DOMAIN_LOGIN'])?>">
: <input type="text" name="DOMAIN_LOGIN" maxlength="40" value="<?=htmlspecialchars(_var($var['DOMAIN_LOGIN']))?>">
_(AD account password)_:
: <input type="password" name="DOMAIN_PASSWD" maxlength="40" value="<?=htmlspecialchars($var['DOMAIN_PASSWD'])?>">
: <input type="password" name="DOMAIN_PASSWD" maxlength="40" value="<?=htmlspecialchars(_var($var['DOMAIN_PASSWD']))?>">
&nbsp;
: <?if ($var['joinStatus']=="Joined"):?>
<input type="submit" name="cmdJoinDomain" value="_(Join)_" disabled><input type="submit" name="cmdLeaveDomain" value="_(Leave)_">
<?else:?>
<input type="submit" name="cmdJoinDomain" value="_(Join)_"><input type="submit" name="cmdLeaveDomain" value="_(Leave)_" disabled>
<?endif;?>
: <span class="inline-block">
<input type="submit" name="cmdJoinDomain" value="_(Join)_" <?=$adJoined ? "disabled" : "";?>>
<input type="submit" name="cmdLeaveDomain" value="_(Leave)_" <?=$adJoined ? "" : "disabled";?>>
</span>
</form>
<br>
<form markdown="1" name="shareOwnership" method="POST" action="/update.htm" target="progressFrame">
_(AD initial owner)_:
: <input type="text" name="shareInitialOwner" maxlength="40" value="<?=htmlspecialchars($var['shareInitialOwner'])?>">
: <input type="text" name="shareInitialOwner" maxlength="40" value="<?=htmlspecialchars(_var($var['shareInitialOwner']))?>">
_(AD initial group)_:
: <input type="text" name="shareInitialGroup" maxlength="40" value="<?=htmlspecialchars($var['shareInitialGroup'])?>">
: <input type="text" name="shareInitialGroup" maxlength="40" value="<?=htmlspecialchars(_var($var['shareInitialGroup']))?>">
&nbsp;
: <span class="inline-block">