mirror/webgui
1
0
Fork 0
mirror of https://github.com/unraid/webgui.git synced 2026-02-23 10:49:52 -06:00
Code Issues Packages Projects Releases Wiki Activity

refactor: enforce theme initialization check in ThemeHelper constructor and remove redundant checks in theme methods

Browse Source
This commit is contained in:
Zack Spear
2025-04-07 13:21:17 -07:00
parent 4feb26d955
commit 78dead079f
1 changed files with 3 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
emhttp/plugins/dynamix/include/ThemeHelper.php
View File

@@ -41,9 +41,10 @@ class ThemeHelper {
* @param string|null $theme The theme name (optional)
*/
public function __construct(?string $theme = null) {
if ($theme !== null) {
$this->initWithCurrentThemeSetting($theme);
if ($theme === null) {
throw new \RuntimeException(self::INIT_ERROR);
}
$this->initWithCurrentThemeSetting($theme);
}
/**
@@ -66,71 +67,37 @@ class ThemeHelper {
}
$this->fgcolor = self::FGCOLORS[$this->themeName] ?? self::COLOR_BLACK;
$this->initialized = true;
}
/**
* Check if the theme has been initialized
*
* @return bool
*/
public function isInitialized(): bool {
return $this->initialized;
}
public function getThemeName(): string {
if (!$this->initialized) {
throw new \RuntimeException(self::INIT_ERROR);
}
return $this->themeName;
}
public function isTopNavTheme(): bool {
if (!$this->initialized) {
throw new \RuntimeException(self::INIT_ERROR);
}
return $this->topNavTheme;
}
public function isSidebarTheme(): bool {
if (!$this->initialized) {
throw new \RuntimeException(self::INIT_ERROR);
}
return $this->sidebarTheme;
}
public function isDarkTheme(): bool {
if (!$this->initialized) {
throw new \RuntimeException(self::INIT_ERROR);
}
return $this->darkTheme;
}
public function isLightTheme(): bool {
if (!$this->initialized) {
throw new \RuntimeException(self::INIT_ERROR);
}
return $this->lightTheme;
}
public function getThemeHtmlClass(): string {
if (!$this->initialized) {
throw new \RuntimeException(self::INIT_ERROR);
}
return $this->themeHtmlClass;
}
public function getFgColor(): string {
if (!$this->initialized) {
throw new \RuntimeException(self::INIT_ERROR);
}
return $this->fgcolor;
}
public function updateDockerLogColor(string $docroot): void {
if (!$this->initialized) {
throw new \RuntimeException(self::INIT_ERROR);
}
exec("sed -ri 's/^\.logLine\{color:#......;/.logLine{color:{$this->fgcolor};/' $docroot/plugins/dynamix.docker.manager/log.htm >/dev/null &");
}