mirror/webgui
1
0
Fork 0
mirror of https://github.com/unraid/webgui.git synced 2026-01-05 17:20:04 -06:00
Code Issues Packages Projects Releases Wiki Activity

chore: update PR plugin build workflow to prevent SHA conflicts

Browse Source 
- Modified the GitHub Actions workflow to generate versioned TXZ URLs and keys, ensuring unique paths for each pull request.
- Updated comments for clarity regarding the purpose of versioning in the upload process.
This commit is contained in:
Eli Bosley
2025-09-10 12:43:43 -04:00
parent 3994f06a65
commit 83d009f891
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
.github/workflows/pr-plugin-build.yml vendored
View File

@@ -49,11 +49,12 @@ jobs:
# Also keep PR info for reference
PR_VERSION="pr.${{ github.event.pull_request.number }}.$(git rev-parse --short HEAD)"
# Generate stable URLs and keys once
# Generate URLs with versioned TXZ to prevent SHA conflicts
S3_BASE_URL="${{ secrets.CLOUDFLARE_PREVIEW_BUCKET_BASE_URL }}/pr-plugins/pr-${{ github.event.pull_request.number }}"
TXZ_URL="${S3_BASE_URL}/webgui-pr-${{ github.event.pull_request.number }}.tar.gz"
# TXZ gets unique versioned path to prevent SHA conflicts on updates
TXZ_URL="${S3_BASE_URL}/webgui-pr-${{ github.event.pull_request.number }}-${VERSION}.tar.gz"
PLUGIN_URL="${S3_BASE_URL}/webgui-pr-${{ github.event.pull_request.number }}.plg"
TXZ_KEY="pr-plugins/pr-${{ github.event.pull_request.number }}/webgui-pr-${{ github.event.pull_request.number }}.tar.gz"
TXZ_KEY="pr-plugins/pr-${{ github.event.pull_request.number }}/webgui-pr-${{ github.event.pull_request.number }}-${VERSION}.tar.gz"
PLUGIN_KEY="pr-plugins/pr-${{ github.event.pull_request.number }}/webgui-pr-${{ github.event.pull_request.number }}.plg"
echo "version=$VERSION" >> $GITHUB_OUTPUT
@@ -108,7 +109,7 @@ jobs:
if: steps.changed-files.outputs.has_changes == 'true'
id: upload-txz
run: |
# Upload to R2 - overwrite existing file for updates
# Upload to R2 with versioned filename to prevent SHA conflicts
aws s3 cp "webgui-pr-${{ github.event.pull_request.number }}.tar.gz" \
"s3://${{ secrets.CLOUDFLARE_PREVIEW_BUCKET_NAME }}/${{ steps.version.outputs.txz_key }}" \
--endpoint-url "${{ secrets.CLOUDFLARE_S3_URL }}" \