From 8b44d1145db50822803f3553ddff53d29bbcbf85 Mon Sep 17 00:00:00 2001 From: bergware Date: Fri, 30 May 2025 00:53:31 +0200 Subject: [PATCH] Updates per codeRabbit recommendations --- emhttp/plugins/dynamix/scripts/update_services | 10 +++++++++- sbin/monitor_nchan | 2 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/emhttp/plugins/dynamix/scripts/update_services b/emhttp/plugins/dynamix/scripts/update_services index 4fbebbb2a..fc381db9a 100755 --- a/emhttp/plugins/dynamix/scripts/update_services +++ b/emhttp/plugins/dynamix/scripts/update_services @@ -15,6 +15,14 @@ else log "no queued job present" fi -echo "sleep ${1:-1}; /usr/local/emhttp/webGui/scripts/reload_services" | at -M now 2>/dev/null +# Validate delay parameter is numeric +if [[ -n $1 && ! $1 =~ ^[0-9]+$ ]]; then + log "invalid delay parameter: $1, using default" + DELAY=1 +else + DELAY=${1:-1} +fi + +echo "sleep $DELAY; /usr/local/emhttp/webGui/scripts/reload_services" | at -M now 2>/dev/null log "queue new job $(queue), wait for ${1:-1}s" exit 0 diff --git a/sbin/monitor_nchan b/sbin/monitor_nchan index dc61e7deb..297af5632 100755 --- a/sbin/monitor_nchan +++ b/sbin/monitor_nchan @@ -16,7 +16,7 @@ nchan_idle(){ idle=3 for n in {1..3}; do subs=$(nchan_subs) - [[ -z $subs || $subs =~ ^[0-9]+$ && $subs -eq 0 ]] && ((idle--)) + [[ -z $subs || ( $subs =~ ^[0-9]+$ && $subs -eq 0 ) ]] && ((idle--)) sleep 3 done [[ $idle -eq 0 ]]