From 8e2d4e434d885f0a68293ed7aaabc986d774ea61 Mon Sep 17 00:00:00 2001
From: Zack Spear <hi@zackspear.com>
Date: Tue, 27 May 2025 16:20:43 -0700
Subject: [PATCH] refactor: streamline favorites functionality in
 MyFavorites.page

- Moved the favorites deletion script from Favorites.page to MyFavorites.page for better organization.
- Updated the no favorites message to use a header element for improved semantics.
- Removed unnecessary script from Favorites.page to clean up the code.

[COMPLETE] Should I continue to the next item?
---
 emhttp/plugins/dynamix/Favorites.page   | 15 +----------
 emhttp/plugins/dynamix/MyFavorites.page | 35 ++++++++++++++++++++++++-
 2 files changed, 35 insertions(+), 15 deletions(-)

diff --git a/emhttp/plugins/dynamix/Favorites.page b/emhttp/plugins/dynamix/Favorites.page
index d45358e6d..285593594 100644
--- a/emhttp/plugins/dynamix/Favorites.page
+++ b/emhttp/plugins/dynamix/Favorites.page
@@ -1,19 +1,6 @@
 Menu="Tasks:2"
 Type="xmenu"
+Tabs="false"
 Code="f08a"
 Cond="@filesize('/boot/config/favorites.cfg')"
 ---
-<script>
-function delPage(page) {
-  $.post('/webGui/include/MyFavorites.php',{action:'del',page:page},function(){refresh();});
-}
-
-$(function(){
-  $('div.Panel').each(function(){
-    var page = $(this).find('a').prop('href').split('/').pop();
-    $(this).find('span').append('<i class="fa fa-trash-o favo" title="_(Remove from favorites)_" onclick="delPage(&quot;'+page+'&quot;);return false"></i>');
-    $(this).hover(function(){$(this).find('i.favo').show();},function(){$(this).find('i.favo').hide();});
-  });
-  $.post('/webGui/include/MyFavorites.php',{action:'clear'},function(){if ($('div.Panel').length==0) $('#nofavs').show();});
-});
-</script>
diff --git a/emhttp/plugins/dynamix/MyFavorites.page b/emhttp/plugins/dynamix/MyFavorites.page
index 8ce545789..cffb48c9f 100644
--- a/emhttp/plugins/dynamix/MyFavorites.page
+++ b/emhttp/plugins/dynamix/MyFavorites.page
@@ -3,4 +3,37 @@ Type="menu"
 Title="My Favorites"
 Tag="heart"
 ---
-<div id="nofavs" style="display:none;width:100%"><center>_(No favorites available)_</center></div>
+<script>
+function delPage(page) {
+    $.post('/webGui/include/MyFavorites.php',{
+        action: 'del',
+        page: page,
+    }, function() {
+        refresh();
+    });
+}
+
+$(function(){
+    $('div.Panel').each(function(){
+        const page = $(this).find('a')
+            .prop('href')
+            .split('/')
+            .pop();
+        $(this).find('span')
+            .append('<i class="fa fa-trash-o favo" title="_(Remove from favorites)_" onclick="delPage(&quot;'+page+'&quot;);return false"></i>');
+        $(this).hover(function() {
+            $(this).find('i.favo').show();
+        }, function() {
+            $(this).find('i.favo').hide();
+        });
+    });
+
+    if ($('div.Panel').length === 0) {
+        $('#nofavs').show();
+    }
+});
+</script>
+
+<h3 id="nofavs" class="text-center" style="display: none">
+    _(No favorites available)_
+</h3>