From 915a79c94e5a7d0db77b84dccca8f57f3e5f7bc4 Mon Sep 17 00:00:00 2001
From: Zack Spear <hi@zackspear.com>
Date: Thu, 29 May 2025 17:04:08 -0700
Subject: [PATCH] fix: tabbed content rendering in MainContentTabbed.php

- Added logic to handle pages without titles but containing text, ensuring proper rendering of content.
- Introduced a mechanism to skip index increment for such pages, maintaining correct tab functionality.
- Improved code readability with better indentation and comments for clarity.
---
 .../DefaultPageLayout/MainContentTabbed.php   | 25 +++++++++++++++++--
 1 file changed, 23 insertions(+), 2 deletions(-)

diff --git a/emhttp/plugins/dynamix/include/DefaultPageLayout/MainContentTabbed.php b/emhttp/plugins/dynamix/include/DefaultPageLayout/MainContentTabbed.php
index b639e55bc..7f251740e 100644
--- a/emhttp/plugins/dynamix/include/DefaultPageLayout/MainContentTabbed.php
+++ b/emhttp/plugins/dynamix/include/DefaultPageLayout/MainContentTabbed.php
@@ -4,6 +4,7 @@
  * Accessible, modern, and decoupled from non-tabbed logic.
  */
 ?>
+
 <div id="displaybox">
     <nav class="tabs" role="tablist" aria-label="Page Tabs">
         <div class="tabs-container">
@@ -26,10 +27,24 @@
         </div>
     </nav>
 
-    <? $i = 0; ?>
+    <?
+        $i = 0;
+        $skipIndexIncrement = false; // used if the page has no title but has text
+    ?>
     <? foreach ($pages as $page): ?>
         <? 
             if (!isset($page['Title'])) {
+                /**
+                 * If the page has no title but has text, we need to eval the content to ensure the page is "rendered".
+                 * For instance Share.page is a parent page that has no title but has text aka content.
+                 * The content consists of some PHP and JS code that needs to be evaluated to ensure it's rendered.
+                 * We'll use the $skipIndexIncrement to skip the index increment. To ensure the tabs are properly rendered.
+                 */
+                if (isset($page['text'])) {
+                    $skipIndexIncrement = true;
+                    annotate($page['file']);
+                    eval('?>'.generateContent($page));
+                }
                 continue;
             }
             $title = processTitle($page['Title']);
@@ -47,7 +62,13 @@
 
             <? eval('?>'.generateContent($page)); ?>
         </section>
-        <? $i++; ?>
+        <?
+            if ($skipIndexIncrement) {
+                $skipIndexIncrement = false;
+            } else {
+                $i++;
+            }
+        ?>
     <? endforeach; ?>
 </div>