From ad342e68b69f646afb0925cd9012c773448c94d1 Mon Sep 17 00:00:00 2001
From: Zack Spear <hi@zackspear.com>
Date: Wed, 7 May 2025 16:15:45 -0700
Subject: [PATCH] refactor: improve scroll position handling in
 BodyInlineJS.php

- Changed the 'top' variable to use parseInt for better type handling.
- Updated the scrollTop logic for clarity and consistency.
---
 .../dynamix/include/DefaultPageLayout/BodyInlineJS.php      | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/emhttp/plugins/dynamix/include/DefaultPageLayout/BodyInlineJS.php b/emhttp/plugins/dynamix/include/DefaultPageLayout/BodyInlineJS.php
index cc980995c..ae5f5eb67 100644
--- a/emhttp/plugins/dynamix/include/DefaultPageLayout/BodyInlineJS.php
+++ b/emhttp/plugins/dynamix/include/DefaultPageLayout/BodyInlineJS.php
@@ -283,8 +283,10 @@ $(function() {
       $(this).attr('onsubmit','clearTimeout(timers.flashReport);escapeQuotes(this);'+onsubmit);
     }
   });
-  var top = ($.cookie('top')||0);
-  if (top>0) {$('html,body').scrollTop(top);}
+  const top = parseInt($.cookie('top') || '0', 10);
+  if (top > 0) {
+    $('html, body').scrollTop(top);
+  }
   $.removeCookie('top');
   if ($.cookie('addAlert') != null) bannerAlert(addAlert.text,addAlert.cmd,addAlert.plg,addAlert.func);
 <?if ($safemode):?>