mirror/webgui
1
0
Fork 0
mirror of https://github.com/unraid/webgui.git synced 2026-04-23 10:38:50 -05:00
Code Issues Packages Projects Releases Wiki Activity

MVP solution for zsh plugin

Browse Source 
Implemented a minimal viable solution for the zsh plugin:
- Checks if the shell is /bin/zsh
- Falls back to bash if not

This approach prioritizes simplicity and reliability over a more general solution to avoid potential errors.
This commit is contained in:
donbuehl
2024-08-26 14:29:24 +02:00
parent be22c0e1f8
commit db77c13552
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
emhttp/plugins/dynamix/include/OpenTerminal.php
+2 -3
View File
@@ -51,9 +51,8 @@ case 'ttyd':
// no child processes, restart ttyd to pick up possible font size change
if ($retval != 0) exec("kill ".$ttyd_pid[0]);
}
$userShell = basename(posix_getpwuid(0)['shell']);
$shell = in_array($userShell, ['bash', 'sh', 'zsh', 'fish', 'ksh', 'tcsh', 'dash']) ? $userShell : 'bash';
if ($retval != 0) exec("ttyd-exec -i '$sock' $shell --login");
$shell = posix_getpwuid(0)['shell'] === '/bin/zsh' ? 'zsh' : 'bash';
if ($retval != 0) exec("ttyd-exec -i '$sock' '$shell' --login");
break;
case 'syslog':
// read syslog file