mirror/webgui
1
0
Fork 0
mirror of https://github.com/unraid/webgui.git synced 2026-05-03 08:19:27 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1978 from dlandon/js_errors_in_share_edit

Browse Source 
Fix JS errors in ShareEdit.
This commit is contained in:
tom mortensen
2025-01-08 09:23:38 -08:00
committed by GitHub
parent 938145fb56 3d0919aa37
commit dec80c4520
1 changed files with 35 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
emhttp/plugins/dynamix/ShareEdit.page
+35 -34
View File
@@ -15,6 +15,10 @@ Tag="share-alt-square"
*/
?>
<?
if (!empty($name) && !array_key_exists($name, $shares)) {
echo "<script>done()</script>";
return;
}
$width = [123,300];
if ($name == "") {
@@ -33,13 +37,9 @@ if ($name == "") {
"cachePool2" => "",
"cow" => "auto"
];
} elseif (array_key_exists($name, $shares)) {
} else {
/* edit existing share. */
$share = $shares[$name];
} else {
/* handle share deleted case. */
echo "<p class='notice'>"._('Share')." '".htmlspecialchars($name)."' "._('has been deleted').".</p><input type='button' value=\""._('Done')."\" onclick='done()'>";
return;
}
/* If the configuration is pools only, then no array disks are available. */
@@ -575,6 +575,7 @@ function initDropdown(forceInit) {
destroyDropdownIfExists('#s5');
<?endif;?>
}
initializeDropdown('#s1', "_(All)_", <?=$width[1]?>);
initializeDropdown('#s2', "_(None)_", <?=$width[1]?>);
initializeDropdown('#s3', "_(All)_", <?=$width[1]?>);
@@ -586,26 +587,42 @@ function initDropdown(forceInit) {
function initializeDropdown(selector, emptyText, width, firstItemChecksAll = false) {
try {
$(selector).dropdownchecklist({
emptyText: emptyText,
width: width,
explicitClose: "..._(close)_",
firstItemChecksAll: firstItemChecksAll
});
if ($(selector).length) {
$(selector).dropdownchecklist({
emptyText: emptyText,
width: width,
explicitClose: "..._(close)_",
firstItemChecksAll: firstItemChecksAll
});
}
} catch (e) {
console.error(`Error initializing ${selector}: ` + e.message);
}
}
function destroyDropdownIfExists(selector) {
try {
$(selector).dropdownchecklist('destroy');
} catch (e) {
if (e.message.includes('prior to initialization')) {
console.log(`${selector} not initialized, skipping destroy.`);
} else {
console.error(`Error destroying ${selector}: ` + e.message);
if ($(selector).length) {
$(selector).dropdownchecklist('destroy');
}
} catch (e) {
}
}
function enableDropdownIfExists(selector) {
try {
if ($(selector).length) {
$(selector).dropdownchecklist('enable');
}
} catch (e) {
}
}
function disableDropdownIfExists(selector) {
try {
if ($(selector).length) {
$(selector).dropdownchecklist('disable');
}
} catch (e) {
}
}
@@ -792,22 +809,6 @@ function updateCOW(pool, slow) {
}
}
function enableDropdownIfExists(selector) {
try {
$(selector).dropdownchecklist('enable');
} catch (e) {
console.log(`${selector} not initialized, cannot enable.`);
}
}
function disableDropdownIfExists(selector) {
try {
$(selector).dropdownchecklist('disable');
} catch (e) {
console.log(`${selector} not initialized, cannot disable.`);
}
}
/* Unite selected options into a comma-separated string */
function unite(field) {
const list = [];