mirror/webgui
1
0
Fork 0
mirror of https://github.com/unraid/webgui.git synced 2026-01-06 01:29:54 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix: write nchan.pid before starting scripts to avoid possible race conditions

Browse Source
This commit is contained in:
Squidly271
2025-08-11 12:57:11 -04:00
parent f52e77d15b
commit edf61fd90f
1 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
emhttp/plugins/dynamix/include/DefaultPageLayout.php
View File

@@ -63,18 +63,17 @@ if (count($pages)) {
$running = file_exists($nchan_pid) ? file($nchan_pid, FILE_IGNORE_NEW_LINES | FILE_SKIP_EMPTY_LINES) : [];
$start = array_diff($nchan, $running); // returns any new scripts to be started
$running = array_merge($start, $running); // update list of current running nchan scripts
// start nchan scripts which are new or have been stopped
foreach ($running as $row) {
$script = explode(':', $row, 2)[0];
$output = [];
exec('pgrep --ns $$ -f ' . escapeshellarg("$docroot/$script"),$output,$retval);
if ($retval !== 0) { // 0=found; 1=none; 2=error
exec(escapeshellarg("$docroot/$script") . ' >/dev/null 2>&1 &');
}
}
// start nchan scripts which are new or have been terminated but still should be running
if (count($running)) {
file_put_contents_atomic($nchan_pid, implode("\n", $running) . "\n");
foreach ($running as $row) {
$script = explode(':', $row, 2)[0];
$output = [];
exec('pgrep --ns $$ -f ' . escapeshellarg("$docroot/$script"),$output,$retval);
if ($retval !== 0) { // 0=found; 1=none; 2=error
exec(escapeshellarg("$docroot/$script") . ' >/dev/null 2>&1 &');
}
}
} else {
@unlink($nchan_pid);
}