tom mortensen
8b3b1ee175
Merge pull request #2351 from unraid/fix/remove-fixed-class
...
fix: update locale select element to remove fixed class
2025-09-04 11:40:17 -07:00
tom mortensen
5e612913fc
Merge pull request #2350 from unraid/fix/null-arry-in-searchlink
...
fix: searchlink can error in the plugin check
2025-09-04 11:39:26 -07:00
tom mortensen
11e08fe691
Merge pull request #2348 from Squidly271/DockerViewMode
...
Fix: Under certain circumstances Advanced/Basic view mode setting wouldn't save
2025-09-04 11:38:41 -07:00
Eli Bosley
963d023362
fix: update locale select element to remove fixed class
2025-09-02 13:00:54 -04:00
Eli Bosley
c364912d08
fix: searchlink can error in the plugin check
...
The error occurred because of how searchLink() is called on line 49:
if ($support = searchLink($info, $url) ?: searchLink($info, newurl($url))) {
Here's the sequence of events that caused the issue:
1. First call: searchLink($info, $url) - This works fine if $info contains the JSON data from
/tmp/community.applications/tempFiles/templates.json
2. If first call returns falsy: The ?: operator (shorthand ternary) triggers the second call:
searchLink($info, newurl($url))
3. The problem: When the first searchLink() returns null or false, PHP's ?: operator evaluates
the second expression. However, if $info itself is null (which can happen if the JSON file
doesn't exist or is empty - see line 19 where readJson() returns [] for missing files), then
searchLink(null, newurl($url)) is called.
4. The crash: Inside searchLink(), when $db is null, calling count($db) throws the TypeError
because count() requires an array or Countable object, not null.
Root causes:
- The JSON file at /tmp/community.applications/tempFiles/templates.json might not exist or could
be corrupted
- The readJson() function returns an empty array [] for missing files, but if the JSON decode
fails, it could return null
- The code wasn't defensive against null values being passed to searchLink()
The fix adds is_array($db) check to ensure we only attempt to count when we have a valid array.
2025-09-02 10:46:46 -04:00
Tom Mortensen
84ae3d6482
* fix: correct handling of case-insensitve share names
2025-08-29 17:13:05 -07:00
Squidly271
7a595edb24
Utilize a general class
2025-08-29 02:25:53 -04:00
Squidly271
38b8c0410b
Fix: Under certain circumstances Advanced/Basic view mode settingnwouldn't save
2025-08-27 22:10:33 -04:00
tom mortensen
62e155e0e8
Merge pull request #2346 from unraid/fix/dashboard-icon-spacing
...
fix: dashboard icon spacing
2025-08-27 08:46:10 -07:00
tom mortensen
a32ab40983
Merge pull request #2345 from unraid/feat/management-access-force-tabbed-view
...
feat: force tabs in Management Access page
2025-08-27 08:45:33 -07:00
tom mortensen
a74b5c95f9
Merge pull request #2344 from unraid/fix/notification-settings-removed-unused-settings-with-new-notifications
...
fix: removed unused notifications settings fields
2025-08-27 08:44:58 -07:00
tom mortensen
c81b54e4b2
Merge pull request #2343 from bergware/master
...
Dashboard: fix network speed calculation
2025-08-27 08:44:03 -07:00
tom mortensen
fb6ce68c42
Merge pull request #2342 from unraid/fix-firefox-cancel-resend
...
Fix: Prevent Firefox from showing resend/cancel popup when starting array
2025-08-27 08:43:22 -07:00
tom mortensen
d8afcb661e
Merge pull request #2341 from unraid/fix/favicon-browser-consistency
...
fix: favicon link structure for browser consistency
2025-08-27 08:42:23 -07:00
Zack Spear
8dae38a3dc
fix: restore margin-right for icon classes in DashStats.css
2025-08-26 12:27:26 -07:00
Zack Spear
4358066844
feat: force tabs in Management Access page
2025-08-26 10:42:11 -07:00
Zack Spear
08d268a8fe
fix: remove auto-close option from notification settings
2025-08-26 10:29:04 -07:00
Zack Spear
e0b405587d
fix: remove unused notification display options from configuration
2025-08-26 10:27:36 -07:00
bergware
9f72b28f99
Dashboard: fix network speed calculation
2025-08-22 11:25:37 +02:00
ljm42
fc91c39389
chore: replace another location.reload()
2025-08-21 19:24:26 -07:00
ljm42
32854d47e8
Fix: Prevent Firefox from showing resend/cancel popup when starting array
2025-08-21 17:44:51 -07:00
Zack Spear
ac906029be
fix: update favicon link structure for browser consistency
2025-08-21 10:44:57 -07:00
Squidly271
d94e1ded6b
Fix: Allow apostrophe in swal text
2025-08-21 00:46:44 -04:00
Tom Mortensen
6ef719f9ee
fix: for zfs pools, for number of slots > 8 select 'raidz2' as defualt
2025-08-20 21:10:34 -07:00
Tom Mortensen
074aa304dc
fix: do not permit new share names to include embedded space characters
2025-08-20 21:10:02 -07:00
Tom Mortensen
ee238ef656
chore: refactor file sysem check scripts again
...
fix: re-arrange raidz vdev selections and establish better defaults
2025-08-20 08:26:30 -07:00
Tom Mortensen
ff34cbd528
fix: share name validation
2025-08-20 08:26:08 -07:00
Tom Mortensen
e8a8291649
feat: exFAT support
...
chore: refactor file sysem check scripts
fix: fix some mode bits
2025-08-15 13:51:36 -07:00
tom mortensen
b9baa461bf
Merge pull request #2338 from Squidly271/patch-8
...
Fixed: Multiple Tabs on Main would cause issues on parity sync changes
2025-08-15 10:03:20 -07:00
Squidly271
680363d54a
Fixed: Multiple Tabs on Main would cause issues on parity sync changes
2025-08-14 19:30:56 -04:00
Zack Spear
a393306a71
fix: update swal input visibility logic
...
- Modified CSS in jquery.sweetalert.css to refine the visibility of the default SweetAlert input fields. The new rule ensures that inputs are hidden unless the class 'show-input' is present on the alert or 'swal-input-show' is applied to the input itself.
2025-08-14 15:38:58 -07:00
tom mortensen
7ff00c2a2f
Merge pull request #2336 from unraid/fix/swal-input-type-text-visibility
...
fix: swal input type text
2025-08-13 22:43:38 -07:00
tom mortensen
6bdc997608
Merge pull request #2335 from unraid/fix/notice-abort-background-process-icon-margin
...
style: remove unnecessary margins abort process notice
2025-08-13 22:43:07 -07:00
Squidly271
173c388b0f
Refactor: Don't time out on scripts that can continue in background and auto exit when finished
2025-08-13 22:56:45 -04:00
Squidly271
4ed31801bc
Refactor: Change to always publish
2025-08-13 22:37:24 -04:00
Squidly271
ac9d97a628
Merge branch 'master' into patch-8
2025-08-13 19:28:12 -04:00
Zack Spear
965a753020
fix: swal input type text
...
- Added 'swal-input-show' class to input fields in Wireless.php to ensure they are displayed correctly.
- Modified CSS in jquery.sweetalert.css to hide default SweetAlert input fields while allowing specific ones to show (hiding was already done in legacy webgui)
2025-08-13 15:03:53 -07:00
Zack Spear
02b9d57115
style: remove unnecessary margins from abortOps class in default-base.css
2025-08-13 12:08:55 -07:00
Squidly271
021afafa41
Refactor:Remove unused global var in JS
2025-08-12 23:21:55 -04:00
Squidly271
c5d984d270
Chore: Remove references to :stop on nchan options
2025-08-12 23:09:23 -04:00
Squidly271
e361b0b864
Refactor: Remove code for live updates disabled
2025-08-12 23:05:48 -04:00
Squidly271
0b57133b82
Update emhttp/plugins/dynamix/include/publish.php
...
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2025-08-12 22:08:05 -04:00
Squidly271
4e733f971e
Fix: nchan script monitoring for Main
2025-08-12 21:39:32 -04:00
Squidly271
22abfc6a5c
Feat: If no listener always publish a msg even if dupe
2025-08-12 12:34:24 -04:00
tom mortensen
ce9b3aba1d
Merge pull request #2330 from unraid/fix/footer-copyright-on-right
...
fix: footer layout and styles for improved responsiveness
2025-08-12 09:18:31 -07:00
tom mortensen
7228b4d33e
Merge pull request #2329 from unraid/fix/file-manager-issues
...
fix: file manager issues
2025-08-12 09:18:01 -07:00
tom mortensen
a24e0f4ef4
Merge pull request #2328 from unraid/fix/tooltips-cutoff
...
fix: tooltip position in array list table
2025-08-12 09:17:17 -07:00
tom mortensen
9509849721
Merge pull request #2327 from Squidly271/patch-11
...
Fix: Prevent nchan scripts from spawning
2025-08-12 09:16:40 -07:00
tom mortensen
fd0ccd228e
Merge pull request #2326 from Squidly271/patch-8
...
Feat: Allow selected nchan publishers to exit if no listeners
2025-08-12 09:15:50 -07:00
Squidly271
3c2c2c2635
Chore: Rename func and set properly set default values
2025-08-12 12:14:37 -04:00