mirror of
https://github.com/unraid/webgui.git
synced 2026-01-04 08:29:51 -06:00
c364912d08
The error occurred because of how searchLink() is called on line 49:
if ($support = searchLink($info, $url) ?: searchLink($info, newurl($url))) {
Here's the sequence of events that caused the issue:
1. First call: searchLink($info, $url) - This works fine if $info contains the JSON data from
/tmp/community.applications/tempFiles/templates.json
2. If first call returns falsy: The ?: operator (shorthand ternary) triggers the second call:
searchLink($info, newurl($url))
3. The problem: When the first searchLink() returns null or false, PHP's ?: operator evaluates
the second expression. However, if $info itself is null (which can happen if the JSON file
doesn't exist or is empty - see line 19 where readJson() returns [] for missing files), then
searchLink(null, newurl($url)) is called.
4. The crash: Inside searchLink(), when $db is null, calling count($db) throws the TypeError
because count() requires an array or Countable object, not null.
Root causes:
- The JSON file at /tmp/community.applications/tempFiles/templates.json might not exist or could
be corrupted
- The readJson() function returns an empty array [] for missing files, but if the JSON decode
fails, it could return null
- The code wasn't defensive against null values being passed to searchLink()
The fix adds is_array($db) check to ensure we only attempt to count when we have a valid array.
74 lines
2.4 KiB
PHP
Executable File
74 lines
2.4 KiB
PHP
Executable File
#!/usr/bin/php -q
|
|
<?PHP
|
|
/* Copyright 2005-2023, Lime Technology
|
|
* Copyright 2012-2023, Bergware International.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License version 2,
|
|
* as published by the Free Software Foundation.
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*/
|
|
?>
|
|
<?
|
|
$docroot ??= ($_SERVER['DOCUMENT_ROOT'] ?: '/usr/local/emhttp');
|
|
require_once "$docroot/plugins/dynamix.plugin.manager/include/PluginHelpers.php";
|
|
|
|
function readJson($file) {
|
|
return is_file($file) ? json_decode(file_get_contents($file),true) : [];
|
|
}
|
|
function newurl($url) {
|
|
$oldURL = 'https://raw.github.com/';
|
|
$newURL = 'https://raw.githubusercontent.com/';
|
|
return str_replace($oldURL,$newURL,$url);
|
|
}
|
|
function searchLink(&$db,$url) {
|
|
if ($url && is_array($db)) for ($i = 0; $i < count($db); $i++) if ( ($db[$i]['PluginURL']??null)==$url) return $db[$i]['Support']??null;
|
|
}
|
|
|
|
$type = $argv[1]??''; // plugin or language
|
|
$method = $argv[2]??''; // install, update, remove, check
|
|
$name = $argv[3]??''; // plugin name (*.plg) or language name (*.xml)
|
|
$error = $argv[4]??''; // error code (empty if none)
|
|
|
|
$plugin = "/boot/config/plugins/$name";
|
|
$pending = "/tmp/plugins/pluginPending";
|
|
|
|
switch ($type) {
|
|
case 'plugin':
|
|
switch ($method) {
|
|
case 'install':
|
|
case 'update':
|
|
// abort if method was unsuccessful
|
|
if ($error) break;
|
|
// update support link in plugin file
|
|
$info = readJson('/tmp/community.applications/tempFiles/templates.json');
|
|
// find matching support link
|
|
$url = plugin('pluginURL', $plugin);
|
|
if ($support = searchLink($info, $url) ?: searchLink($info, newurl($url))) {
|
|
// update incorrect or missing support links
|
|
if (plugin('support', $plugin) != $support) {
|
|
$xml = @simplexml_load_file($plugin);
|
|
if ($xml->xpath('//PLUGIN/@support')[0]??false) {
|
|
// support link exists, update it
|
|
$xml->xpath('//PLUGIN/@support')[0] = $support;
|
|
} else {
|
|
// support link is missing, add it
|
|
$xml->addAttribute('support', $support);
|
|
}
|
|
echo "Updating support link\n";
|
|
file_put_contents($plugin, $xml->saveXML());
|
|
}
|
|
}
|
|
}
|
|
break;
|
|
case 'language':
|
|
// nothing defined
|
|
break;
|
|
}
|
|
|
|
// unset pending status
|
|
if ($method != 'check') @unlink("$pending/$name");
|
|
?>
|