mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-06 21:59:54 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge topic 'fix-isspace-usage-for-signed-char'

Browse Source 
5e8c176e2a cmExecuteProcessCommand: Cast c to unsigned char before cast to int

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !9132
This commit is contained in:
Brad King
2024-01-08 14:44:10 +00:00
committed by Kitware Robot
parent ddb608b1d9 5e8c176e2a
commit 2cc792ba29
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Source/cmExecuteProcessCommand.cxx
View File

@@ -35,7 +35,11 @@
namespace {
bool cmExecuteProcessCommandIsWhitespace(char c)
{
return (isspace(static_cast<int>(c)) || c == '\n' || c == '\r');
// isspace takes 'int' but documents that the value must be representable
// by 'unsigned char', or EOF. Cast to 'unsigned char' to avoid sign
// extension while casting to 'int'.
return (isspace(static_cast<int>(static_cast<unsigned char>(c))) ||
c == '\n' || c == '\r');
}
void cmExecuteProcessCommandFixText(std::vector<char>& output,