mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-05-25 01:28:50 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge topic 'findbase_dont_erase_outofbounds_entry'

Browse Source 
f5837f0ac9 cmFindBase: Don't pass vector::erase an out of bounds iterator

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !10331
This commit is contained in:
Brad King
2025-02-12 14:23:26 +00:00
committed by Kitware Robot
parent 52f6845f21 f5837f0ac9
commit 6bd903551e
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/cmFindBase.cxx
+4 -2
View File
@@ -356,14 +356,16 @@ struct entry_to_remove
{
if (this->valid()) {
long to_skip = this->count;
long index_to_remove = 0;
size_t index_to_remove = 0;
for (auto const& path : entries) {
if (path == this->value && --to_skip == 0) {
break;
}
++index_to_remove;
}
entries.erase(entries.begin() + index_to_remove);
if (index_to_remove < entries.size() && to_skip == 0) {
entries.erase(entries.begin() + index_to_remove);
}
}
}