mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-02 03:39:43 -06:00
Code Issues Packages Projects Releases Wiki Activity

CMake GUI: Don't use QToolButton

Browse Source 
Replace QToolButton instances with QPushButton. QToolButton is only
meant to be used on tool bars and some other special situations. Worse,
we had a mix of QToolButton and QPushButton for things that clearly
should be using the same widget. This will improve visual consistency
and may fix some rendering issues.
This commit is contained in:
Matthew Woehlke
2021-01-15 11:24:16 -05:00
parent 0bc327a79c
commit 8aebd159fc
3 changed files with 4 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Source/QtDialog/CMakeSetupDialog.cxx
View File

@@ -22,7 +22,6 @@
#include <QShortcut>
#include <QStatusBar>
#include <QString>
#include <QToolButton>
#include <QUrl>
#include <QVector>

10
Source/QtDialog/CMakeSetupDialog.ui
View File

@@ -208,7 +208,7 @@
</widget>
</item>
<item>
<widget class="QToolButton" name="AddEntry">
<widget class="QPushButton" name="AddEntry">
<property name="toolTip">
<string>Add New Entry</string>
</property>
@@ -219,13 +219,10 @@
<iconset resource="CMakeSetup.qrc">
<normaloff>:/Icons/Plus16.png</normaloff>:/Icons/Plus16.png</iconset>
</property>
<property name="toolButtonStyle">
<enum>Qt::ToolButtonTextBesideIcon</enum>
</property>
</widget>
</item>
<item>
<widget class="QToolButton" name="RemoveEntry">
<widget class="QPushButton" name="RemoveEntry">
<property name="toolTip">
<string>Remove Selected Entries</string>
</property>
@@ -236,9 +233,6 @@
<iconset resource="CMakeSetup.qrc">
<normaloff>:/Icons/Delete16.png</normaloff>:/Icons/Delete16.png</iconset>
</property>
<property name="toolButtonStyle">
<enum>Qt::ToolButtonTextBesideIcon</enum>
</property>
</widget>
</item>
<item>

10
Source/QtDialog/EnvironmentDialog.ui
View File

@@ -46,7 +46,7 @@
</spacer>
</item>
<item>
<widget class="QToolButton" name="AddEntry">
<widget class="QPushButton" name="AddEntry">
<property name="text">
<string>&amp;Add Entry</string>
</property>
@@ -54,13 +54,10 @@
<iconset resource="CMakeSetup.qrc">
<normaloff>:/Icons/Plus16.png</normaloff>:/Icons/Plus16.png</iconset>
</property>
<property name="toolButtonStyle">
<enum>Qt::ToolButtonTextBesideIcon</enum>
</property>
</widget>
</item>
<item>
<widget class="QToolButton" name="RemoveEntry">
<widget class="QPushButton" name="RemoveEntry">
<property name="text">
<string>&amp;Remove Entry</string>
</property>
@@ -68,9 +65,6 @@
<iconset resource="CMakeSetup.qrc">
<normaloff>:/Icons/Delete16.png</normaloff>:/Icons/Delete16.png</iconset>
</property>
<property name="toolButtonStyle">
<enum>Qt::ToolButtonTextBesideIcon</enum>
</property>
</widget>
</item>
</layout>