mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-06 21:59:54 -06:00
Code Issues Packages Projects Releases Wiki Activity

CMP0028: Report backtrace to link item rather than target creation

Browse Source 
Now that we have proper backtraces for both `LINK_LIBRARIES` and
`INTERFACE_LINK_LIBRARIES` entries, we can report them in error
messages.
This commit is contained in:
Brad King
2021-12-16 12:19:25 -05:00
parent 0dcbf4ab58
commit a97c92e46e
7 changed files with 18 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Source/cmGeneratorTarget.cxx
View File

@@ -2722,8 +2722,12 @@ public:
<< "\" but the target was not found. Perhaps a find_package() "
"call is missing for an IMPORTED target, or an ALIAS target is "
"missing?";
cmListFileBacktrace backtrace = item.Backtrace;
if (backtrace.Empty()) {
backtrace = this->Target->GetBacktrace();
}
this->Target->GetLocalGenerator()->GetCMakeInstance()->IssueMessage(
messageType, e.str(), this->Target->GetBacktrace());
messageType, e.str(), backtrace);
}
}
return;

4
Tests/RunCMake/CMP0028/CMP0028-NEW-iface-stderr.txt
View File

@@ -1,6 +1,6 @@
CMake Error at CMP0028-NEW-iface.cmake:6 \(add_library\):
CMake Error at CMP0028-NEW-iface\.cmake:5 \(target_link_libraries\):
Target "foo" links to target "External::Library" but the target was not
found. Perhaps a find_package\(\) call is missing for an IMPORTED target, or
an ALIAS target is missing\?
Call Stack \(most recent call first\):
CMakeLists.txt:3 \(include\)
CMakeLists\.txt:[0-9]+ \(include\)

4
Tests/RunCMake/CMP0028/CMP0028-NEW-stderr.txt
View File

@@ -1,6 +1,6 @@
CMake Error at CMP0028-NEW.cmake:4 \(add_library\):
CMake Error at CMP0028-NEW\.cmake:5 \(target_link_libraries\):
Target "foo" links to target "External::Library" but the target was not
found. Perhaps a find_package\(\) call is missing for an IMPORTED target, or
an ALIAS target is missing\?
Call Stack \(most recent call first\):
CMakeLists.txt:3 \(include\)
CMakeLists\.txt:[0-9]+ \(include\)

4
Tests/RunCMake/CMP0028/CMP0028-WARN-iface-stderr.txt
View File

@@ -1,4 +1,4 @@
CMake Warning \(dev\) at CMP0028-WARN-iface.cmake:4 \(add_library\):
CMake Warning \(dev\) at CMP0028-WARN-iface\.cmake:3 \(target_link_libraries\):
Policy CMP0028 is not set: Double colon in target name means ALIAS or
IMPORTED target. Run "cmake --help-policy CMP0028" for policy details.
Use the cmake_policy command to set the policy and suppress this warning.
@@ -7,5 +7,5 @@ CMake Warning \(dev\) at CMP0028-WARN-iface.cmake:4 \(add_library\):
found. Perhaps a find_package\(\) call is missing for an IMPORTED target, or
an ALIAS target is missing\?
Call Stack \(most recent call first\):
CMakeLists.txt:3 \(include\)
CMakeLists\.txt:[0-9]+ \(include\)
This warning is for project developers. Use -Wno-dev to suppress it.

4
Tests/RunCMake/CMP0028/CMP0028-WARN-stderr.txt
View File

@@ -1,4 +1,4 @@
CMake Warning \(dev\) at CMP0028-WARN.cmake:2 \(add_library\):
CMake Warning \(dev\) at CMP0028-WARN\.cmake:3 \(target_link_libraries\):
Policy CMP0028 is not set: Double colon in target name means ALIAS or
IMPORTED target. Run "cmake --help-policy CMP0028" for policy details.
Use the cmake_policy command to set the policy and suppress this warning.
@@ -7,5 +7,5 @@ CMake Warning \(dev\) at CMP0028-WARN.cmake:2 \(add_library\):
found. Perhaps a find_package\(\) call is missing for an IMPORTED target, or
an ALIAS target is missing\?
Call Stack \(most recent call first\):
CMakeLists.txt:3 \(include\)
CMakeLists\.txt:[0-9]+ \(include\)
This warning is for project developers. Use -Wno-dev to suppress it.

2
Tests/RunCMake/target_link_libraries/CMP0079-link-NEW-bogus-stderr.txt
View File

@@ -1,4 +1,4 @@
^CMake Error at CMP0079-link-NEW-bogus.cmake:[0-9]+ \(add_executable\):
^CMake Error at CMP0079-link-NEW-bogus\.cmake:6 \(set_property\):
Target "top" links to target "::@\(0xdeadbeef\)" but the target was not
found. Perhaps a find_package\(\) call is missing for an IMPORTED target, or
an ALIAS target is missing\?

8
Tests/RunCMake/target_link_libraries/ConfigCase-stderr.txt
View File

@@ -1,13 +1,13 @@
^CMake Error at ConfigCase.cmake:[0-9]+ \(add_library\):
^CMake Error at ConfigCase\.cmake:6 \(target_link_libraries\):
Target "impl" links to target "config::impl-Debug" but the target was not
found. Perhaps a find_package\(\) call is missing for an IMPORTED target, or
an ALIAS target is missing\?
Call Stack \(most recent call first\):
CMakeLists.txt:[0-9]+ \(include\)
CMakeLists\.txt:[0-9]+ \(include\)
+
CMake Error at ConfigCase.cmake:[0-9]+ \(add_library\):
CMake Error at ConfigCase\.cmake:4 \(target_link_libraries\):
Target "impl" links to target "config::iface-Debug" but the target was not
found. Perhaps a find_package\(\) call is missing for an IMPORTED target, or
an ALIAS target is missing\?
Call Stack \(most recent call first\):
CMakeLists.txt:[0-9]+ \(include\)
CMakeLists\.txt:[0-9]+ \(include\)