mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-08 06:40:48 -06:00
Code Issues Packages Projects Releases Wiki Activity

Tests: Add host to ENV{no_proxy} when DNS lookup failure is expected

Browse Source 
DNS lookup of an invalid host name fails with a different error in a proxy
environment than it does in an environment without proxy.  Many tools,
including curl, use the `no_proxy` environment variable to provid a list
of hosts for which proxy should not be used.

To make lookup failure consistent, add invalid host names to the
`no_proxy` environment variable in tests that attempt to look up invalid
host names.  This way the lookup will fail consistently regardless of
whether proxy is generally used or not.

Signed-off-by: william.r.dieter <william.r.dieter@intel.com>
This commit is contained in:
william.r.dieter
2021-01-29 13:39:34 -05:00
parent c5691f03e5
commit c0b1f5f30c
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Tests/CMakeTests/FileDownloadTest.cmake.in
View File

@@ -136,6 +136,9 @@ __reportIfWrongStatus("${status}" 0)
# Print status because we check its message too
message(STATUS "${status}")
# do not use proxy for lookup of invalid site (DNS failure by proxy looks
# different than DNS failure without proxy)
set(ENV{no_proxy} "$ENV{no_proxy},badhostname.invalid")
message(STATUS "FileDownload:11")
file(DOWNLOAD
badhostname.invalid

4
Tests/RunCMake/ctest_submit/CTestConfig.cmake.in
View File

@@ -3,3 +3,7 @@
# so that any ctest_submit calls fail with an error message.
set(CTEST_DROP_METHOD "@CASE_DROP_METHOD@")
set(CTEST_DROP_SITE "@CASE_DROP_SITE@")
# do not use proxy for lookup of invalid site (DNS failure by proxy looks
# different than DNS failure without proxy)
set(ENV{no_proxy} "$ENV{no_proxy},@CASE_DROP_SITE@")