mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-06 05:40:54 -06:00
Code Issues Packages Projects Releases Wiki Activity

cmGlobalXCodeGenerator: Convert CreateString signature to string_view

Browse Source
This commit is contained in:
Brad King
2025-06-06 07:37:50 -04:00
parent 39da8f69a1
commit ced6b31c48
4 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Source/cmGlobalXCodeGenerator.cxx
View File

@@ -850,7 +850,7 @@ cmXCodeObject* cmGlobalXCodeGenerator::CreateObject(cmXCodeObject::Type type)
return ptr;
}
cmXCodeObject* cmGlobalXCodeGenerator::CreateString(std::string const& s)
cmXCodeObject* cmGlobalXCodeGenerator::CreateString(cm::string_view s)
{
cmXCodeObject* obj = this->CreateObject(cmXCodeObject::STRING);
obj->SetString(s);

2
Source/cmGlobalXCodeGenerator.h
View File

@@ -192,7 +192,7 @@ private:
cmXCodeObject* CreateObject(cmXCodeObject::PBXType ptype,
cm::string_view key = {});
cmXCodeObject* CreateObject(cmXCodeObject::Type type);
cmXCodeObject* CreateString(std::string const& s);
cmXCodeObject* CreateString(cm::string_view s);
cmXCodeObject* CreateObjectReference(cmXCodeObject*);
cmXCodeObject* CreateFlatClone(cmXCodeObject*);
cmXCodeObject* CreateXCodeTarget(cmGeneratorTarget* gtgt,

5
Source/cmXCodeObject.cxx
View File

@@ -4,6 +4,7 @@
#include <ostream>
#include <cm/string_view>
#include <cmext/string_view>
char const* cmXCodeObject::PBXTypeNames[] = {
@@ -225,7 +226,7 @@ void cmXCodeObject::PrintString(std::ostream& os) const
cmXCodeObject::PrintString(os, this->String);
}
void cmXCodeObject::SetString(std::string const& s)
void cmXCodeObject::SetString(cm::string_view s)
{
this->String = s;
this->String = std::string(s);
}

3
Source/cmXCodeObject.h
View File

@@ -12,6 +12,7 @@
#include <utility>
#include <vector>
#include <cm/string_view>
#include <cmext/algorithm>
class cmGeneratorTarget;
@@ -64,7 +65,7 @@ public:
bool IsEmpty() const;
void SetString(std::string const& s);
void SetString(cm::string_view s);
std::string const& GetString() const { return this->String; }
void AddAttribute(std::string const& name, cmXCodeObject* value)