Commit Graph

34806 Commits

Author SHA1 Message Date
Brad King
2e16fca2be Merge topic 'cxxmodules-cmp0155-graceful-fallback-without-scanner'
1f507580a1 cmGlobalGenerator: give context about module queries
889aa0354a CMP0155: ignore scanning for sources if no scanner is available

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Merge-request: !8925
2023-11-01 13:48:15 -04:00
Brad King
0deae254e0 Merge topic 'ctest-windows-color'
2553a78aa7 ctest: Allow colored output on Windows if CLICOLOR_FORCE is set to 1

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !8932
2023-11-01 10:06:59 -04:00
Ben Boeckel
1f507580a1 cmGlobalGenerator: give context about module queries
Some queries are merely investigating support in order to change
behavior. Let the method know so that any internal errors can be skipped
over.
2023-11-01 09:52:13 -04:00
Ben Boeckel
889aa0354a CMP0155: ignore scanning for sources if no scanner is available
This allows for a more graceful transition for projects using C++20
without scanner support (e.g., Clang 15 or GCC 13). While newer
compilers will (needlessly) scan, it allows C++20-using projects to use
older compilers without having to set `CMAKE_CXX_SCAN_FOR_MODULES` to
support newer CMake minimum versions.

Fixes: #25357
2023-11-01 09:52:08 -04:00
Cristian Adam
2553a78aa7 ctest: Allow colored output on Windows if CLICOLOR_FORCE is set to 1
Windows 10 supports ANSI colors since v1511. For earlier versions of Windows
installing ANSICON will enable ANSI colors in cmd.exe.

For those setups where the environment is set up with CLICOLOR_FORCE set
to 1 ctest should honor the setting and emit colored ANSI output.
2023-11-01 09:43:59 -04:00
Kitware Robot
fdf6435427 CMake Nightly Date Stamp 2023-11-01 00:01:07 -04:00
Brad King
04c33e0990 Merge topic 'modules-depends-via-target-objects'
22da18b995 Fortran: Restore support for TARGET_OBJECTS providing modules
64d9240564 cmComputeLinkInformation: skip over linking to items for object purposes
035302b7e3 cmComputeLinkDepends: also copy the target from object link items
861876b936 Tests/ObjectLibrary: fix comment

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Acked-by: scivision <michael@scivision.dev>
Merge-request: !8923
2023-10-31 09:12:30 -04:00
Brad King
3a515b31b3 Merge topic 'modules-depends-via-target-objects' into release-3.28
22da18b995 Fortran: Restore support for TARGET_OBJECTS providing modules
64d9240564 cmComputeLinkInformation: skip over linking to items for object purposes
035302b7e3 cmComputeLinkDepends: also copy the target from object link items
861876b936 Tests/ObjectLibrary: fix comment

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Acked-by: scivision <michael@scivision.dev>
Merge-request: !8923
2023-10-31 09:12:28 -04:00
Kitware Robot
d1906daebf CMake Nightly Date Stamp 2023-10-31 00:01:08 -04:00
Ben Boeckel
22da18b995 Fortran: Restore support for TARGET_OBJECTS providing modules
Continue b665966933 (cmComputeLinkInformation: track OBJECT library
dependencies, 2023-07-22) which added explicitly listed `OBJECT`
libraries to the list of targets which the collator needs to consider.
Now also consider targets which provide objects directly to the target
via a `$<TARGET_OBJECT>` source lists.

Also add tests which use target objects directly and through an
`INTERFACE` library with target objects in its own sources.

Fixes: #25365
2023-10-30 10:06:12 -04:00
Brad King
728646434f Merge topic 'cxxmodules-ninja-forced-rsp-files'
09c962a6a4 Tests/CXXModules: test forced rsp files with ninja

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Merge-request: !8926
2023-10-30 08:26:09 -04:00
Brad King
6474d5d03a Merge topic 'cxxmodules-ninja-forced-rsp-files' into release-3.28
09c962a6a4 Tests/CXXModules: test forced rsp files with ninja

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Merge-request: !8926
2023-10-30 08:26:08 -04:00
Brad King
ea52c7bd78 Merge topic 'cmp0153-suggestion'
d3cc815c98 CMP0153: Add suggestion to use execute_process()
8313d26198 cmState::AddDisallowedCommand(): Allow additional warning info

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Acked-by: Brad King <brad.king@kitware.com>
Merge-request: !8921
2023-10-30 08:22:17 -04:00
Kitware Robot
832f548d7c CMake Nightly Date Stamp 2023-10-30 00:01:23 -04:00
Kitware Robot
76c08300ca CMake Nightly Date Stamp 2023-10-29 00:01:07 -04:00
Kitware Robot
fbce5b627c CMake Nightly Date Stamp 2023-10-28 00:01:09 -04:00
Ben Boeckel
09c962a6a4 Tests/CXXModules: test forced rsp files with ninja
Fixes: #25367
2023-10-27 23:55:39 -04:00
Ben Boeckel
64d9240564 cmComputeLinkInformation: skip over linking to items for object purposes
If a name is only found because it is a link entry of kind `Object`, do
not add anything to the link line.
2023-10-27 15:52:01 -04:00
Ben Boeckel
035302b7e3 cmComputeLinkDepends: also copy the target from object link items 2023-10-27 13:25:33 -04:00
Kyle Edwards
d3cc815c98 CMP0153: Add suggestion to use execute_process() 2023-10-27 09:43:18 -04:00
Kyle Edwards
8313d26198 cmState::AddDisallowedCommand(): Allow additional warning info 2023-10-27 09:42:53 -04:00
Brad King
f884a94a0b Merge topic 'cpack-archive-dedup'
770efceccb CPack: Avoid adding duplicate files to archive when combining components

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Merge-request: !8839
2023-10-27 09:07:49 -04:00
Brad King
f55043f87e Merge topic 'unity-build-objc'
e218db1a90 Unity: Enable UNITY_BUILD for OBJC and OBJCXX files

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !8906
2023-10-27 09:06:44 -04:00
Brad King
9627ef86c9 Merge topic 'debugger-function-name-in-stacktrace'
c028425df9 Debugger: report function name in DAP stackframes

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !8913
2023-10-27 09:04:06 -04:00
Brad King
e46e1837dd Merge topic 'fix-Wdeprecated-this-capture'
07e9734790 Source: Fix clang -Wdeprecated-this-capture warnings

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !8917
2023-10-27 08:59:52 -04:00
Brad King
0ca2253087 Merge topic 'fix-Wstrict-prototypes'
81022213f6 Modules: Fix clang -Wstrict-prototypes warnings
47c3334203 Source: Fix clang -Wstrict-prototypes warnings
264dcae5e4 Tests: Fix clang -Wstrict-prototypes warnings

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Merge-request: !8916
2023-10-27 08:58:43 -04:00
Kitware Robot
be3c18e265 CMake Nightly Date Stamp 2023-10-27 00:01:12 -04:00
Atılhan Emre Dursunoğlu
770efceccb CPack: Avoid adding duplicate files to archive when combining components
Fixes: #25280
2023-10-26 18:20:48 +03:00
Rob Raguet-Schofield
e218db1a90 Unity: Enable UNITY_BUILD for OBJC and OBJCXX files 2023-10-26 10:01:41 -04:00
Dmitry.Neverov
c028425df9 Debugger: report function name in DAP stackframes
Before a file name and a line were returned, but they can be
obtained by other means.

Fixes: #25091
2023-10-26 09:51:32 -04:00
Brad King
91e4d86df3 Merge topic 'hint-about-missing-extension-on-windows'
186673ba0b cmGlobalGenerator: hint about missing extensions on Windows

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Merge-request: !8914
2023-10-26 09:42:43 -04:00
Sean McBride
07e9734790 Source: Fix clang -Wdeprecated-this-capture warnings
Explicitly capture variables used in the lambda.
2023-10-26 09:24:54 -04:00
Sean McBride
47c3334203 Source: Fix clang -Wstrict-prototypes warnings 2023-10-26 09:20:45 -04:00
Kitware Robot
2ae35c5657 CMake Nightly Date Stamp 2023-10-26 00:01:07 -04:00
Kitware Robot
35424aab2e CMake Nightly Date Stamp 2023-10-25 00:01:10 -04:00
Brad King
e3747a2d4b CMake 3.28.0-rc3 2023-10-24 13:46:27 -04:00
Ben Boeckel
186673ba0b cmGlobalGenerator: hint about missing extensions on Windows
Discussed on Discourse:

    https://discourse.cmake.org/t/cross-compiling-from-a-windows-host-targeting-raspbian-32-bits-arm/9250
2023-10-24 11:21:31 -04:00
Brad King
c54cb0000d Merge topic 'vector-emplace-back'
9ca6dfc280 Source: Reduce vector entry allocations and copies
aaeb2e0aa8 cmLinkItemGraphVisitor: Remove unnecessary syntax
d1c1e95331 cmCPackInnoSetupGenerator: Reserve space to reduce allocations

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !8891
2023-10-24 08:33:07 -04:00
Brad King
fd3c95140e Merge topic 'misc-warnings'
6ed999674c Fix clang -Wdeprecated-pragma warnings by removing deprecated ATOMIC_VAR_INIT
162e017b2d Fix clang -Wstrict-prototypes by making main take void instead of nothing
b373a22991 Fix clang -Wreserved-identifier by renaming an enum

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Acked-by: scivision <michael@scivision.dev>
Merge-request: !8905
2023-10-24 08:31:55 -04:00
Brad King
2b14b21e40 Merge topic 'cmcldeps-quote-rc'
03080d18eb cmcldeps: Restore support for rc.exe path not fully GetShortPathName-d

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !8912
2023-10-24 08:29:09 -04:00
Brad King
81dc8b9db8 Merge topic 'cmcldeps-quote-rc' into release-3.28
03080d18eb cmcldeps: Restore support for rc.exe path not fully GetShortPathName-d

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !8912
2023-10-24 08:29:08 -04:00
Brad King
b8e280dd93 Merge topic 'source_group-TREE-no-FILES'
8bb949fc30 source_group: Restore behavior of TREE with empty FILES

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Merge-request: !8910
2023-10-24 08:27:21 -04:00
Kitware Robot
a2c4b234f2 CMake Nightly Date Stamp 2023-10-24 00:01:07 -04:00
Brad King
03080d18eb cmcldeps: Restore support for rc.exe path not fully GetShortPathName-d
In some cases `GetShortPathNameW` may not remove all spaces.  If that
happens with the path to `rc.exe`, cmcldeps needs to explicitly quote
the path in the command it runs.

This was exposed by commit 50a6e78a82 (cmSystemTools::RunSingleCommand():
Replace cmsysProcess with cmUVProcessChain, 2023-07-25, v3.28.0-rc1~138^2~4)
because the underlying process execution library no longer reconstructs the
command line without quotes around commands without spaces.

Fixes: #25355
2023-10-23 17:03:01 -04:00
Rose
9ca6dfc280 Source: Reduce vector entry allocations and copies
Prefer `emplace_back` over `push_back`.
2023-10-23 11:18:32 -04:00
Rose
aaeb2e0aa8 cmLinkItemGraphVisitor: Remove unnecessary syntax 2023-10-23 11:14:54 -04:00
Rose
d1c1e95331 cmCPackInnoSetupGenerator: Reserve space to reduce allocations 2023-10-23 11:13:46 -04:00
Brad King
8bb949fc30 source_group: Restore behavior of TREE with empty FILES
Since commit d85238a2f2 (source_group: Fix TREE without FILES,
2023-06-29, v3.28.0-rc1~399^2~1) we incorrectly treat a FILES
argument with no values as if it were not given at all.

Fixes: #25353
2023-10-23 10:53:28 -04:00
Brad King
8a79a20257 Merge topic 'ninja-minor-cleanups'
c2e949b700 cmGlobalNinjaGenerator: remove unnecessary virtual method
1cfba13004 cmGlobalNinjaGenerator: fix lambda variable name typo
f02c3c6181 cmFileCommand: combine string literals

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Merge-request: !8901
2023-10-23 09:40:27 -04:00
Brad King
e93ad8eecd Merge topic 'ninja-better-order-depends'
ed45432571 cmNinjaTargetGenerator: do not order-depend on C++ module sources
0973cd6702 cmNinjaTargetGenerator: use the file set visibility API
4625170925 cmFileSet: add a query for includeable file set types
51f9d9f0a2 cmNinjaTargetGenerator: avoid traversing old outputs repeatedly

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Merge-request: !8902
2023-10-23 09:39:23 -04:00