Commit Graph

66424 Commits

Author SHA1 Message Date
eutro 3ecf6bd1b1 cmake-mode.el: fix bracket string/comment syntax-propertize
With `lexical-binding: t`, the `end` variable is undefined in
`cmake--syntax-propertize-until-bracket-close`, causing syntax
highlighting errors. This fixes that by passing `end` from the caller.
2024-06-24 09:51:05 -04:00
Brad King b14218c9f6 Merge branch 'release-3.29' into release-3.30 2024-06-24 09:40:46 -04:00
Brad King d1c614d87e Merge topic 'libuv-macos-kqueue' into release-3.30
422c1de564 libuv: macos: restore use of kqueue instead of posix poll
7e3519e705 libuv: macos: reap child processes more reliably when using kqueue

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9619
2024-06-24 09:38:41 -04:00
Brad King 1deb543089 Merge topic 'libuv-macos-kqueue' into release-3.29
422c1de564 libuv: macos: restore use of kqueue instead of posix poll
7e3519e705 libuv: macos: reap child processes more reliably when using kqueue

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9619
2024-06-24 09:37:18 -04:00
Brad King 1c4c5ad545 Merge topic 'ctest-windows-std-handles' into release-3.29
e4d0169107 ctest: Fix spurious build failures with CTEST_USE_LAUNCHERS on Windows

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9598
2024-06-24 09:36:19 -04:00
Brad King c3046ea289 Merge topic 'link-feature-attributes-stabilization' into release-3.30
576567f028 Link feature attributes: stabilization
5617c34c31 Libraries processing: update configuration wording

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9607
2024-06-24 09:22:47 -04:00
Brad King c43dc60c64 Merge topic 'nmc-config-list' into release-3.30
b1a804d616 Ninja Multi-Config: Fix crash if config list is changed in subdirectory
9f8afacb3e cmGlobalNinjaGenerator: Reuse local generator caching of config list
48b911e3e5 cmGlobalNinjaGenerator: Factor out helper for global config list lookup
e2c6a54b07 cmGlobalNinjaGenerator: De-duplicate CMAKE_CONFIGURATION_TYPES lookup

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !9618
2024-06-24 09:21:12 -04:00
Brad King 422c1de564 libuv: macos: restore use of kqueue instead of posix poll
Revert commit f54ec4e7f9 (libuv: macos: use posix poll instead of
kqueue, 2024-03-31, v3.29.1~7^2) and its parent.  It is not necessary
after the kqueue-based implementation was fixed to reap child processes
more reliably.

Issue: #25839
2024-06-21 16:45:55 -04:00
Brad King 7e3519e705 libuv: macos: reap child processes more reliably when using kqueue
Backport libuv commit `42cc412c4a` (darwin,process: feed kevent the
signal to reap children, 2023-02-01, `v1.45.0~55`) from libuv PR 3893.

Fixes: #25839
2024-06-21 15:01:15 -04:00
Brad King b1a804d616 Ninja Multi-Config: Fix crash if config list is changed in subdirectory
Look up the value of `CMAKE_CONFIGURATION_TYPES` only in the top level
directory.

Fixes: #26064
2024-06-21 12:21:36 -04:00
Brad King 9f8afacb3e cmGlobalNinjaGenerator: Reuse local generator caching of config list 2024-06-21 10:59:30 -04:00
Brad King 48b911e3e5 cmGlobalNinjaGenerator: Factor out helper for global config list lookup 2024-06-21 10:51:21 -04:00
Brad King e2c6a54b07 cmGlobalNinjaGenerator: De-duplicate CMAKE_CONFIGURATION_TYPES lookup 2024-06-21 10:51:21 -04:00
Brad King 8019272afd Merge topic 'doc-cpack-nuget' into release-3.30
a08faa1a2a Help: Mention CPack/NuGet additions in the 3.30 release notes

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9613
2024-06-21 10:41:15 -04:00
Marc Chevrier 576567f028 Link feature attributes: stabilization
* enhance OVERRIDE handling
* Update wording
2024-06-21 11:18:20 +02:00
Marc Chevrier 5617c34c31 Libraries processing: update configuration wording 2024-06-21 11:18:12 +02:00
Alex Turbov a08faa1a2a Help: Mention CPack/NuGet additions in the 3.30 release notes 2024-06-20 11:52:04 -04:00
Brad King 68243b7c0b Merge topic 'doc-cpack-nuget' into release-3.30
dbdca56555 Help: CPack/NuGet avoid deprecated variables in the usage example
d06a39dd59 Help: CPack/NuGet add `:Supported:` to some variables
a6a8212ba2 Help: CPack/NuGet add description to the added variables
039bf0f3f3 Help: CPack/NuGet fix `versionadded` position
391e339926 Help: CPack/NuGet add deprecation notes according to the current spec
4e11de312b Help: Reorder variables as they mentioned in the official spec

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9605
2024-06-19 08:53:10 -04:00
Brad King ad41a224e2 Merge topic 'cpackrpm_owner_execute' into release-3.30
f73ad97220 CPack/RPM: Fix debuginfo permissions check

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9603
2024-06-18 11:01:52 -04:00
Brad King c3821911f8 Merge branch 'release-3.29' into release-3.30 2024-06-17 15:19:47 -04:00
Brad King cdc901797a CMake 3.29.6 v3.29.6 2024-06-17 14:49:43 -04:00
Brad King 52c83457cd Merge topic 'doc-link-library-features' into release-3.30
c4fdf01a84 Help: Improve link library feature properties docs

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9599
2024-06-17 14:40:59 -04:00
Alex Turbov dbdca56555 Help: CPack/NuGet avoid deprecated variables in the usage example 2024-06-17 11:57:18 -04:00
Adrian DC f73ad97220 CPack/RPM: Fix debuginfo permissions check
Replace non-existent 'USER_EXECUTE' with intended 'OWNER_EXECUTE'.

Signed-off-by: Adrian DC <radian.dc@gmail.com>
2024-06-17 11:54:16 -04:00
Alex Turbov d06a39dd59 Help: CPack/NuGet add :Supported: to some variables
Some features of NuGet require relatively fresh versions.
Mention that versions as they are specified in the upstream spec.
2024-06-17 11:47:35 -04:00
Alex Turbov a6a8212ba2 Help: CPack/NuGet add description to the added variables 2024-06-17 11:47:35 -04:00
Alex Turbov 039bf0f3f3 Help: CPack/NuGet fix versionadded position
It should be right after `.. variable::`
2024-06-17 11:47:35 -04:00
Alex Turbov 391e339926 Help: CPack/NuGet add deprecation notes according to the current spec 2024-06-17 11:47:35 -04:00
Alex Turbov 4e11de312b Help: Reorder variables as they mentioned in the official spec
Also, group 'em into sub-sub-sections (same as in the upstream doc).
See also, https://learn.microsoft.com/en-us/nuget/reference/nuspec
2024-06-17 11:47:35 -04:00
Brad King 4556f91517 Merge topic 'ci-cmake-update' into release-3.30
4e2037032d ci: Update CMake version to 3.30.0-rc3

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !9601
2024-06-15 07:26:07 -04:00
Craig Scott c4fdf01a84 Help: Improve link library feature properties docs 2024-06-15 15:45:38 +10:00
Brad King 4e2037032d ci: Update CMake version to 3.30.0-rc3 2024-06-14 10:22:11 -04:00
Brad King 456ad1e7c0 CMake 3.30.0-rc3 v3.30.0-rc3 2024-06-14 09:32:58 -04:00
Brad King 6bf32b7ae6 Merge topic 'doc-cleanup' into release-3.30
6636b11997 Help: Minor grammar and formatting cleanup
c2390f7676 Help: Fix nuget example with unwanted comment and bad use of rst link

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9600
2024-06-14 09:28:18 -04:00
Brad King 224e7b922f Merge topic 'ctest-windows-std-handles' into release-3.30
e4d0169107 ctest: Fix spurious build failures with CTEST_USE_LAUNCHERS on Windows

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Merge-request: !9598
2024-06-14 09:27:04 -04:00
Brad King 646a81fec7 Merge branch 'release-3.29' into release-3.30 2024-06-14 09:25:30 -04:00
Brad King 296fdc0df1 Merge topic 'vs-quote-semicolons' into release-3.29
9b672e8075 VS: Quote custom command arguments containing semicolons

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9597
2024-06-14 09:24:48 -04:00
Brad King c10ac9e86c Merge topic 'vs-quote-semicolons' into release-3.30
9b672e8075 VS: Quote custom command arguments containing semicolons

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9597
2024-06-14 09:24:31 -04:00
Brad King 5a37d2f734 Merge topic 'xcode-16' into release-3.30
b243c19986 Tests: Update expected results for Xcode 16

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9596
2024-06-14 09:23:29 -04:00
Brad King 9b672e8075 VS: Quote custom command arguments containing semicolons
The `GoogleTest` module needs this to pass the `TEST_EXECUTOR`
definition to its `GoogleTestAddTests.cmake` helper script in
the `POST_BUILD` command since commit f875c479f5 (GoogleTest: Honor
TEST_LAUNCHER in gtest_discover_tests, 2024-01-17, v3.29.0-rc1~34^2).
Previously it worked only if other characters, such as spaces,
caused the argument to be quoted.  This was exposed by running the
`RunCMake.GoogleTest` test in a path without spaces.

Reported-by: Garrett Campbell <gcampbell@microsoft.com>
2024-06-14 08:24:21 -04:00
Brad King e4d0169107 ctest: Fix spurious build failures with CTEST_USE_LAUNCHERS on Windows
Remove the stdio handle inheritance suppression originally added by
commit f262298bb0 (... do not inherit pipes in child procs for ctest so
it can kill them, 2007-09-11, v2.6.0~1136).  It's not clear what problem
it was trying to solve, was only done in `ctest` and not `cmake`, and
since commit 9c3ffe2474 (BUG: fix problem with stdout and stderr not
showing up in ms dos shells, 2007-09-25, v2.6.0~1066) has not been done
in `ctest` launched under interactive consoles.

Furthermore, the code has been spuriously breaking stdio when `ctest` is
started with both stdout and stderr connected to the same pipe, such as
when `ctest --launch` is used under `ninja`.  This is because it used
`DuplicateHandle` with `DUPLICATE_CLOSE_SOURCE` on the stdout handle and
then the stderr handle.  If the handles are the same, then the stderr
handle becomes invalid in between these operations, leading to
likely-undefined behavior.  Since commit 96b3dd329e
(cmCTestLaunchReporter: Replace cmsysProcess with cmUVProcessChain,
2023-07-26, v3.28.0-rc1~138^2~2) this became more noticeable because
`uv_spawn` performs additional verification on stdio handles.

This could be fixed by instead suppressing inheritance via

    SetHandleInformation(h, HANDLE_FLAG_INHERIT, 0);

However, the functionality no longer seems necessary, so remove it.
2024-06-14 07:32:29 -04:00
Craig Scott 6636b11997 Help: Minor grammar and formatting cleanup 2024-06-14 16:19:28 +10:00
Craig Scott c2390f7676 Help: Fix nuget example with unwanted comment and bad use of rst link 2024-06-14 16:17:49 +10:00
Brad King b243c19986 Tests: Update expected results for Xcode 16
In `Tests/RunCMake/LinkerSelection`, Xcode 16 warns when building the
AppleClassic case:

    ld: warning: -ld_classic is deprecated and will be removed
                 in a future release

Tolerate all build warnings.
2024-06-13 09:16:34 -04:00
Brad King aecdab3833 CMake 3.30.0-rc2 v3.30.0-rc2 2024-06-12 09:22:29 -04:00
Brad King 1ffd1da90a Merge topic 'rel-win-wix-4' into release-3.30
f6c2f64d04 Utilities/Release: Update MSI generation to use WIX 4
a8cecc3b7f ci: Update CMake version to 3.30.0-rc1

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9591
2024-06-11 11:25:58 -04:00
Brad King 056eb8954c Merge branch 'release-3.29' into release-3.30 2024-06-11 10:57:22 -04:00
Brad King 4036eafd95 Merge topic 'clang-ansi-color' into release-3.30
1004cc2b52 Clang: Drop non-existent -fno-ansi-escape-codes flag

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9592
2024-06-11 10:56:48 -04:00
Brad King 7c6dcba646 Merge branch 'release-3.28' into release-3.29 2024-06-11 10:56:10 -04:00
Brad King 578ba81424 Merge topic 'clang-ansi-color' into release-3.29
1004cc2b52 Clang: Drop non-existent -fno-ansi-escape-codes flag

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9592
2024-06-11 10:55:59 -04:00