Commit Graph

29380 Commits

Author SHA1 Message Date
Ben McMorran
37a279f8d1 Ninja: Write msvc_deps_prefix as UTF-8 when console codepage is UTF-8 2020-08-06 23:36:03 -07:00
Kitware Robot
ac4e9e10db CMake Nightly Date Stamp 2020-08-07 00:01:37 -04:00
Lemures Lemniscati
8edbc59e46 install: Use case-sensitive pattern matching on Cygwin
Based on downstream patch from Cygwin package for CMake by Marco Atzeri:

* 64864eb8f0/cmake/3.17.3-case-sensitivity.patch
2020-08-06 12:36:38 -04:00
Brad King
4daf76e10a Merge topic 'compiler_flags'
f76c20da63 Toolchain: Test compiler initial settings
db486da265 Toolchain: Update documentation for initial compiler flags
deec2f587c Toolchain: Take CMAKE_<lang>_FLAGS_INIT into account during compiler detection
ca899af3e2 Toolchain: Handle repeated invocations of CMake with -DCMAKE_C_COMPILER
12ba89e142 Toolchain: Make `/path/comp;-argn' behave the same as 'comp;-argn'
6f1af899db Toolchain: Capture all arguments from CMAKE_<LANG>_COMPILER
ec1d3bc0b6 cmake: avoid exception when printing "changed variables" message

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4136
2020-08-06 11:00:12 -04:00
Brad King
5c56aaa284 Merge topic 'update-kwsys'
05e3abafa5 Merge branch 'upstream-KWSys' into update-kwsys
82fd685043 KWSys 2020-08-05 (185dd56e)

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5104
2020-08-06 10:51:59 -04:00
Brad King
c1297edab6 Merge topic 'cmake-find-package-mode-help'
c0e4a0bd82 cmake: Update --help output to discourage use of --find-package mode

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Michael Hirsch, Ph.D. <michael@scivision.dev>
Merge-request: !5099
2020-08-06 10:51:04 -04:00
Brad King
b1892fb98c Merge topic 'FixTooManyOpenFiles'
57f250dcc0 Graphviz: Fix issue with too many open file streams on Windows platform

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5088
2020-08-06 10:45:35 -04:00
Brad King
89e5f95c2b Merge topic 'reuse_pch_no_delay'
ef97fbe6c2 PCH: Avoid unnecessary 30s delay on MSBuild Generator with REUSE_FROM

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5102
2020-08-06 10:39:47 -04:00
Brad King
030aa9dc30 Merge topic 'automoc_timestamp_deps'
9a9ed4b9d3 Merge branch 'backport-3.17-automoc_timestamp_deps'
7445c9a58a AutoGen: Add test to check for correct AutoMoc dependencies
a79056bb02 AutoGen: Fix over-specified direct dependencies of custom command

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Aleix <aleixpol@kde.org>
Merge-request: !5085
2020-08-06 10:31:23 -04:00
Brad King
06427db62c Merge topic 'ninja-multi-rsp-remove-path'
cdb50af2f6 Ninja: Restore shorter path to response files

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: alcroito <alexandru.croitor@qt.io>
Merge-request: !5094
2020-08-06 10:28:27 -04:00
Felix Yan
5dd710286f Correct a typo in cmFileCommand.cxx 2020-08-06 10:25:51 -04:00
Kitware Robot
9d03b623e7 CMake Nightly Date Stamp 2020-08-06 00:01:13 -04:00
Brad King
05e3abafa5 Merge branch 'upstream-KWSys' into update-kwsys
# By KWSys Upstream
* upstream-KWSys:
  KWSys 2020-08-05 (185dd56e)
2020-08-05 16:29:07 -04:00
Cristian Adam
ef97fbe6c2 PCH: Avoid unnecessary 30s delay on MSBuild Generator with REUSE_FROM
Fix logic added by commit 1f791eb160 (Multi-Ninja: Fix reusable PCHs for
MSVC, 2020-05-24, v3.18.0-rc1~72^2) to avoid an unnecessary delay.

Fixes: #21054
2020-08-05 15:52:05 -04:00
Brad King
9a9ed4b9d3 Merge branch 'backport-3.17-automoc_timestamp_deps' 2020-08-05 15:42:39 -04:00
Tobias Ribizel
562dcec3c4 CTest: Add error types to cuda-memcheck parser 2020-08-05 10:51:44 +02:00
Kitware Robot
b26c35620c CMake Nightly Date Stamp 2020-08-05 00:01:09 -04:00
Brad King
c0e4a0bd82 cmake: Update --help output to discourage use of --find-package mode
Fixes: #21056
2020-08-04 12:02:54 -04:00
Kitware Robot
5becf28f92 CMake Nightly Date Stamp 2020-08-04 00:01:15 -04:00
Alexandru Croitor
a79056bb02 AutoGen: Fix over-specified direct dependencies of custom command
The AutoMoc timestamp creating custom command explicitly depended
on all dependencies of the origin target (associated to the AutoGen
target).

When an origin target depended on a shared library 'libfoo.so',
if it was re-linked, the AutoMoc custom command would touch its
output timestamp file, and thus cause needless rebuilding of sources,
despite the shared library not having any influence on the AutoMoc
generated files.

Introduce a new '<target>_autogen_timestamp_deps' utility target,
which will serve as an 'order-only' dependency for the custom command.

This will prevent needless rebuilding, because touching 'libfoo.so'
will not cause the custom command to be re-executed.

The new AutoMoc dependency tree looks like:
    '_autogen_timestamp_deps (serves as order-only dep)'
 <- '<target_autogen>/timestamp' file ( + moc deps file)
 <- '<target>_autogen' target.

Fixes: #21020
2020-08-03 19:38:11 +02:00
Ben McMorran
67599c7ada cmGeneratedFileStream: Add WriteRaw method 2020-08-03 12:56:41 -04:00
Kyle Edwards
cdb50af2f6 Ninja: Restore shorter path to response files
In commit 99ed39b011 (Ninja Multi-Config: Make link response files
per-config, 2020-07-15, v3.17.4~3^2), we added the target directory to
the response file under the mistaken assumption that two different
targets with the same name could be in different directories. However,
this causes the path to the response file to be too long to fit on a
command line.  Take the path back out, while leaving in the per-config
split.

Fixes: #21050
2020-08-03 12:14:16 -04:00
Brad King
afb998704e Remove filtering of allowed INTERFACE library properties
Previously we disallowed use of arbitrary properties on INTERFACE
libraries.  The goal was to future-proof projects using them by not
allowing properties to be set that may affect their future inclusion in
the generated buildsystem.  In order to prepare to actually include
INTERFACE libraries in the generated buildsystem, drop the filter and
allow arbitrary properties to be set.

Issue: #19145
2020-08-03 10:04:23 -04:00
Brad King
e7edba2baf Makefiles: Use IsInBuildSystem in global generator target type checks
Follow up from commit 422d9a0ab2 (Factor out generator checks for
filtering out interface libraries, 2020-07-20) with more uses of
`IsInBuildSystem`.
2020-08-03 10:04:22 -04:00
Kitware Robot
4b1e2449fa CMake Nightly Date Stamp 2020-08-03 00:01:07 -04:00
Kitware Robot
508e25e21e CMake Nightly Date Stamp 2020-08-02 00:01:11 -04:00
Kitware Robot
03d3cc1136 CMake Nightly Date Stamp 2020-08-01 00:01:06 -04:00
Stephan Rohmen
57f250dcc0 Graphviz: Fix issue with too many open file streams on Windows platform
Fixes #20931
2020-07-31 22:26:08 +02:00
Kitware Robot
383090bf59 CMake Nightly Date Stamp 2020-07-31 00:01:10 -04:00
Brad King
63a65baf4c CMake 3.18.1 2020-07-30 12:34:59 -04:00
Brad King
103d6faed9 CMake 3.17.4 2020-07-30 10:30:07 -04:00
Brad King
8878f59cf9 Merge topic 'unity_no_skip_autogen'
7051250a6c Unity Builds: Do not set SKIP_AUTOGEN to source files

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5081
2020-07-30 08:28:49 -04:00
Kitware Robot
3595e37519 CMake Nightly Date Stamp 2020-07-30 00:01:12 -04:00
Cristian Adam
7051250a6c Unity Builds: Do not set SKIP_AUTOGEN to source files
Fixes: #21028
2020-07-29 17:57:50 +02:00
Fred Baksik
ca899af3e2 Toolchain: Handle repeated invocations of CMake with -DCMAKE_C_COMPILER
Repeated invocations of `cmake ... -DCMAKE_C_COMPILER=gcc` should not
trigger a "You have changed variables" message even though the cache
value of CMAKE_C_COMPILER changes from '/path/to/gcc' to 'gcc'.

Make repeated invocations of `cmake ... -DCMAKE_C_COMPILER=gcc;-pipe`
not trigger the warning by comparing the compiler name portion of the list to
the compiler being used.
2020-07-29 11:51:27 -04:00
Brad King
62d876e4e3 Merge topic 'cmcomputecomponentgraph-compute-method'
bd0d03386b cmComputeComponentGraph: Move work out of constructor into Compute() method

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5079
2020-07-29 08:10:57 -04:00
Brad King
8a521f5e10 Merge topic 'refactor_cmTarget_language_initProperties'
6f1c04055f cmTarget: Refactor init of common language properties

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5077
2020-07-29 08:10:09 -04:00
Brad King
783c6e0455 Merge topic 'use-nonempty'
f37c14e930 Source: use cmNonempty()

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5072
2020-07-29 08:08:02 -04:00
Brad King
f04c68fab3 Merge topic 'noduplicates'
78357e98a4 Avoid duplicate calls to GetDefinition

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5073
2020-07-29 08:07:04 -04:00
Kitware Robot
49c600952e CMake Nightly Date Stamp 2020-07-29 00:02:15 -04:00
Kyle Edwards
bd0d03386b cmComputeComponentGraph: Move work out of constructor into Compute() method
The computation of Tarjan's algorithm is an expensive operation which
should not be done in the constructor. Move this work into a dedicated
Compute() method, and call this method explicitly.
2020-07-28 15:30:56 -04:00
Robert Maynard
6f1c04055f cmTarget: Refactor init of common language properties 2020-07-28 12:37:44 -04:00
Craig Scott
22bfe014d0 Merge topic 'file-download-no-save'
fed7d8f76d file(DOWNLOAD): Make file argument optional

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5060
2020-07-28 10:23:35 -04:00
Vitaly Stakhovsky
78357e98a4 Avoid duplicate calls to GetDefinition 2020-07-28 09:12:16 -04:00
Vitaly Stakhovsky
f37c14e930 Source: use cmNonempty() 2020-07-28 08:31:31 -04:00
Brad King
261a2585d9 Merge topic 'cleanup-target-types'
ef796cc743 cmGeneratorTarget: Skip computing link implementation for custom targets
45158b2afe cmGeneratorTarget: Simplify logic in ComputeLinkInterfaceLibraries
d6b1f5704e cmGeneratorTarget: Add missing nullptr checks
7695b67500 cmComputeTargetDepends: Add missing nullptr check
95b5df8646 cmGeneratorTarget: Skip computing languages for custom targets
2f0790df50 Factor out generator checks for filtering on non-compiling targets
422d9a0ab2 Factor out generator checks for filtering out interface libraries
bce82df0aa cmGeneratorTarget: Remove unnecessary target type check in dependency tracing
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kyle Edwards <kyle.edwards@kitware.com>
Merge-request: !5038
2020-07-28 08:26:23 -04:00
Brad King
79d341d4d4 Merge topic 'cmctest-stdstring'
825b04c67a cmCTest: Members accept std::string parameters

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5064
2020-07-28 08:25:47 -04:00
Brad King
dde97681e9 Merge topic 'revert-add_test-special-chars' into release-3.18
5fc5f4d26e add_test: Revert "Allow special characters in test name"

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5067
2020-07-28 08:24:34 -04:00
Brad King
40d3f5a227 Merge topic 'revert-add_test-special-chars'
5fc5f4d26e add_test: Revert "Allow special characters in test name"

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5067
2020-07-28 08:24:34 -04:00
Brad King
1091e64177 Merge topic 'update-kwsys'
ead4adad75 Merge branch 'upstream-KWSys' into update-kwsys
36819d99c1 KWSys 2020-07-24 (c3054d90)

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5055
2020-07-28 08:23:45 -04:00