Added validation

This commit is contained in:
Daniel Cojocea
2024-07-19 18:04:58 -04:00
parent 4a14d1c8d9
commit 1aef3300f0
4 changed files with 69 additions and 20 deletions

View File

@@ -43,6 +43,14 @@
.configure-monitor .config-box .MuiStack-root {
flex: 1;
}
.configure-monitor .MuiStack-root:has(span.MuiTypography-root.input-error) {
position: relative;
}
.configure-monitor span.MuiTypography-root.input-error {
position: absolute;
top: 100%;
}
.MuiInputBase-root:has(#monitor-interval) {
height: 34px;
}

View File

@@ -14,6 +14,7 @@ import PauseCircleOutlineIcon from "@mui/icons-material/PauseCircleOutline";
import KeyboardArrowDownIcon from "@mui/icons-material/KeyboardArrowDown";
import "./index.css";
import { monitorValidation } from "../../../Validation/validation";
const formatDurationRounded = (ms) => {
const seconds = Math.floor(ms / 1000);
@@ -66,6 +67,14 @@ const Configure = () => {
const { authToken } = useSelector((state) => state.auth);
const { monitorId } = useParams();
const idMap = {
"monitor-url": "url",
"monitor-name": "name",
"monitor-type": "type",
"monitor-interval": "interval",
};
const [config, setConfig] = useState();
const [monitor, setMonitor] = useState();
const [errors, setErrors] = useState({});
useEffect(() => {
@@ -76,17 +85,45 @@ const Configure = () => {
},
});
let data = res.data.data;
setConfig(data);
setMonitor({
name: data.name,
url: data.url.replace(/^https?:\/\//, ""),
type: data.type,
interval: data.interval / MS_PER_MINUTE,
status: data.status,
});
};
fetchMonitor();
}, [monitorId, authToken]);
const handleChange = (event) => {
const { value, id } = event.target;
const name = idMap[id];
setMonitor((prev) => ({
...prev,
[name]: value,
}));
const validation = monitorValidation.validate(
{ [name]: value },
{ abortEarly: false }
);
setErrors((prev) => {
const updatedErrors = { ...prev };
if (validation.error)
updatedErrors[name] = validation.error.details[0].message;
else delete updatedErrors[name];
return updatedErrors;
});
};
const handleSubmit = (event) => {
event.preventDefault();
// TODO
};
const frequencies = [1, 2, 3, 4, 5];
return (
@@ -114,25 +151,25 @@ const Configure = () => {
<form className="configure-monitor-form" noValidate spellCheck="false">
<Stack gap={theme.gap.xl}>
<Stack direction="row" gap={theme.gap.small} mt={theme.gap.small}>
{monitor?.status ? <GreenCheck /> : <RedCheck />}
{config?.status ? <GreenCheck /> : <RedCheck />}
<Box>
<Typography component="h1" sx={{ lineHeight: 1 }}>
{monitor?.url.replace(/^https?:\/\//, "") || "..."}
{config?.url.replace(/^https?:\/\//, "") || "..."}
</Typography>
<Typography mt={theme.gap.small}>
<Typography
component="span"
sx={{
color: monitor?.status
color: config?.status
? "var(--env-var-color-17)"
: "var(--env-var-color-24)",
}}
>
Your site is {monitor?.status ? "up" : "down"}.
Your site is {config?.status ? "up" : "down"}.
</Typography>{" "}
Checking every {formatDurationRounded(monitor?.interval)}. Last
Checking every {formatDurationRounded(config?.interval)}. Last
time checked{" "}
{formatDurationRounded(getLastChecked(monitor?.checks))} ago.
{formatDurationRounded(getLastChecked(config?.checks))} ago.
</Typography>
</Box>
<Stack
@@ -185,7 +222,9 @@ const Configure = () => {
id="monitor-url"
label="URL to monitor"
placeholder="google.com"
value={monitor?.url}
value={monitor?.url || ""}
onChange={handleChange}
error={errors["url"]}
/>
<Field
type="text"
@@ -193,7 +232,9 @@ const Configure = () => {
label="Friendly name"
isOptional={true}
placeholder="Google"
value={monitor?.name}
value={monitor?.name || ""}
onChange={handleChange}
error={errors["name"]}
/>
</Stack>
</Stack>

View File

@@ -5,7 +5,7 @@ import RadioButton from "../../../Components/RadioButton";
import Button from "../../../Components/Button";
import { Box, MenuItem, Select, Stack, Typography } from "@mui/material";
import { useSelector, useDispatch } from "react-redux";
import { createMonitorValidation } from "../../../Validation/validation";
import { monitorValidation } from "../../../Validation/validation";
import { createMonitor } from "../../../Features/Monitors/monitorsSlice";
import { useNavigate } from "react-router-dom";
import { useTheme } from "@emotion/react";
@@ -37,7 +37,7 @@ const CreateMonitor = () => {
// });
//Advanced Settings Form
const [advancedSettings, setAdvancedSettings] = useState({
frequency: 1,
interval: 1,
// retries: "",
// codes: "",
// redirects: "",
@@ -57,7 +57,7 @@ const CreateMonitor = () => {
[id]: checkbox ? true : value,
}));
const validation = createMonitorValidation.validate(
const validation = monitorValidation.validate(
{ [id]: value },
{ abortEarly: false }
);
@@ -92,7 +92,7 @@ const CreateMonitor = () => {
...checks,
};
const { error } = createMonitorValidation.validate(monitor, {
const { error } = monitorValidation.validate(monitor, {
abortEarly: false,
});
@@ -107,8 +107,8 @@ const CreateMonitor = () => {
...monitor,
description: monitor.name,
userId: user._id,
// ...advancedSettings, // TODO frequency should be interval, then we can use spread
interval: advancedSettings.frequency * MS_PER_MINUTE,
// ...advancedSettings
interval: advancedSettings.interval * MS_PER_MINUTE,
};
try {
const action = await dispatch(createMonitor({ authToken, monitor }));
@@ -333,10 +333,10 @@ const CreateMonitor = () => {
</Typography>
<Select
id="monitor-frequencies"
value={advancedSettings.frequency || 1}
value={advancedSettings.interval || 1}
inputProps={{ id: "monitor-frequencies-select" }}
onChange={(event) =>
handleChange(event, "frequency", setAdvancedSettings)
handleChange(event, "interval", setAdvancedSettings)
}
MenuProps={{
PaperProps: {

View File

@@ -73,7 +73,7 @@ const credentials = joi.object({
}),
});
const createMonitorValidation = joi.object({
const monitorValidation = joi.object({
url: joi
.string()
.trim()
@@ -85,7 +85,7 @@ const createMonitorValidation = joi.object({
.string()
.trim()
.messages({ "string.empty": "*This field is required." }),
frequency: joi.number().messages({
interval: joi.number().messages({
"number.base": "*Frequency must be a number.",
"any.required": "*Frequency is required.",
}),
@@ -106,4 +106,4 @@ const imageValidation = joi.object({
}),
});
export { credentials, imageValidation, createMonitorValidation };
export { credentials, imageValidation, monitorValidation };