[release] v0.15.7-unstable2

changelog.md

@@ -1,5 +1,6 @@
 ## Version 0.15.7
  - Added "Allow insecure local connection" for HTTP ip:port access in the same network
+ - Fix issue where Cosmos request IP based certs to LE if setup
 
 ## Version 0.15.6
  - accept any insecure TLS when option is on

client/src/pages/newInstall/newInstall.jsx

@@ -104,7 +104,7 @@ const NewInstall = () => {
                 ["SELFSIGNED", "Generate self-signed certificate (recommended)"],
                 ["PROVIDED", "Supply my own HTTPS certificate"],
                 ["DISABLED", "Use HTTP only (not recommended)"],
-            ] 
+            ]
         }
     }
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "cosmos-server",
-  "version": "0.15.7-unstable1",
+  "version": "0.15.7-unstable2",
   "description": "",
   "main": "test-server.js",
   "bugs": {

src/utils/certificates.go

@@ -206,8 +206,18 @@ func DoLetsEncrypt() (string, string) {
 	}
 	myUser.Registration = reg
 
+	domainsDirty := GetAllHostnames(true, true)
+	domains := []string{}
+	
+	// remove ips
+	for i := 0; i < len(domains); i++ {
+		if !IsIP(domains[i]) {
+			domains = append(domains, domains[i])
+		}
+	}
+
 	request := certificate.ObtainRequest{
-		Domains: LetsEncryptValidOnly(GetAllHostnames(true, false), config.HTTPConfig.DNSChallengeProvider != ""),
+		Domains: LetsEncryptValidOnly(domains, config.HTTPConfig.DNSChallengeProvider != ""),
 		Bundle:  true,
 	}
 	certificates, err := client.Certificate.Obtain(request)