Address PR comments

This commit is contained in:
Malin Ejdbo
2021-04-07 17:25:58 +02:00
parent e91d833c65
commit 3ec01fa25e
6 changed files with 103 additions and 96 deletions

View File

@@ -127,15 +127,10 @@ RenderableModelProjection::RenderableModelProjection(const ghoul::Dictionary& di
p.projection
);
double boundingSphereRadius = 1.0e9;
if (p.boundingSphereRadius.has_value()) {
boundingSphereRadius = *p.boundingSphereRadius;
}
double boundingSphereRadius = p.boundingSphereRadius.value_or(1.0e9);
setBoundingSphere(boundingSphereRadius);
if (p.performShading.has_value()) {
_performShading = *p.performShading;
}
_performShading = p.performShading.value_or(_performShading);
addProperty(_performShading);
}