mirror/OpenSpace
1
0
Fork 0
mirror of https://github.com/OpenSpace/OpenSpace.git synced 2026-02-25 06:19:02 -06:00
Code Issues Packages Projects Releases Wiki Activity

Update ghoul to keep full precision when converting Lua value to string

Browse Source 
And update tests that use the conversion

Fixes lost precision when printing navigation state from openspace.navigation.getNavigationState()
This commit is contained in:
Emma Broman
2022-07-04 16:28:14 +02:00
parent db36b2dec5
commit b0968392c5
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ext/ghoul

Submodule ext/ghoul updated: 7dc41a163e...dd259016f3

6
tests/property/test_property_listproperties.cpp
View File

@@ -221,7 +221,7 @@ TEST_CASE("IntListProperty: Get Lua Value", "[intlistproperty]") {
p.getLuaValue(L);
CHECK(ghoul::lua::luaValueToString(L, 1) ==
"{ [1] = 1.000000, [2] = 2.000000, [3] = 3.000000 }"
"{ [1] = 1, [2] = 2, [3] = 3 }"
);
}
@@ -324,14 +324,14 @@ TEST_CASE("DoubleListProperty: Invalid Set Lua Value - Not List", "[doublelistpr
TEST_CASE("DoubleListProperty: Get Lua Value", "[doublelistproperty]") {
openspace::properties::DoubleListProperty p({ "id", "gui", "desc" });
const std::vector<double> list{ 1.0, 2.0, 3.0 };
const std::vector<double> list{ 1.0, 2.1, 3.2 };
p.setValue(list);
ghoul::lua::LuaState L;
p.getLuaValue(L);
CHECK(ghoul::lua::luaValueToString(L, 1) ==
"{ [1] = 1.000000, [2] = 2.000000, [3] = 3.000000 }"
"{ [1] = 1, [2] = 2.1, [3] = 3.2 }"
);
}