Commit Graph

331 Commits

Author SHA1 Message Date
Gene Payne
cec6e05ff1 Allow Window Config GUI to Edit Files (#2574)
* Added pboettch/json-schema-validator submodule

* Added initial code for selecting window config to edit

* Use updated sgct submodule with json-validate

* Bump sgct submodule version reference

* Bump sgct submodule version reference

* Version checking of sgct window config in progress

* Json schema validator submodule is now in sgct

* Added support for read-only window configs, and additional changes

* More changes with opening config in window edit, plus schema files added

* Update sgct schema version with more defs to work with sgctedit schema

* Fixes to get sgct edit schema working with dialog for error messages

* Improvements in exception handling

* Improved handling of multiple sgct & json exception types

* Minor improvements in exception messages

* Extra spaces in error message output

* Fixing importing of json config data from launcher to sgctedit

* Fixed window size & position update

* Changes for preserving settings in edit vs new mode

* Changes to import settings from config file

* More changes for importing testing of config file based on file tests

* Fixed window placement dims in monitor, and some code refactoring

* Move json validation before initial read

* Add CMake copy of sgct schema file to OpenSpace post-build

* Bump sgct submodule reference

* Modify calls for json schema validation and bump to latest sgct

* Bump to new sgct repo with unit testing and updated schema

* Added first test for window config editor schema

* Finished tests for sgcteditor validation

* Code cleanup pass

* Fix of sgctedit test for remove description

* CMake and include config changes to fix build after merge

* Bump sgct submodule version

* Improve paths in sgctedit test

* Bump sgct reference for test path fix

* Check for imported monitor number being in valid range

* Make sgct config 'monitor' key/value optional

* Have 'save' or 'save as' buttons depending on edit or new modes

* Code review feedback changes

* Fix to include the last file in the user config dir list

* Addressing some PR request

* Change to pass-by-reference in editRefusalDialog

* Separating errors into summary and detailed messages in error dialog

* Disable edit button with hover text if config read shows invalid format

---------

Co-authored-by: Alexander Bock <alexander.bock@liu.se>
2023-04-14 18:28:31 -06:00
Alexander Bock
80e2aaf564 Remove whitespaces at the end of files, ' and - characters 2023-04-05 16:58:45 +02:00
Alexander Bock
3df65ae899 Simplify property handling; Fix unit tests 2023-03-11 15:58:40 +01:00
Alexander Bock
23ee2ee5da Add new verifier to handle identifiers and update codegen to be able to use them (closes #2522) 2023-03-11 13:18:12 +01:00
Gene Payne
4d64d833a8 Typo in NewHorizonsModel.ostest file 2023-02-22 09:44:50 -07:00
GPayne
f8d43103bd Updated image testing .ostest files with updated action names 2023-02-21 14:37:52 -07:00
Alexander Bock
79ad5776cc CMake cleanup (#2489)
* CMake Cleanup
* Warning suppression with CEF
* Use SGCT tinyxml in skybrowser for now
* Disable warnings about missing field initializers
2023-02-05 23:24:12 +01:00
Gene Payne
dfc62e44a6 Changes to visual tests mainly to switch from keys to actions (#2484)
* Changing 'keys' test case to 'action' in all .ostest files
* Change recording files to use the standard extension
* Add recording file extension to test file format
* Removed the unwanted second wildcard from set prop command
* Added 10 sec waits after profile.setup.apollo11 action in some tests
2023-02-03 16:30:10 -07:00
Alexander Bock
1a88d898d8 Update submodules 2023-02-01 23:41:55 +01:00
Alexander Bock
d52c5dd0d9 Cleanup code with designated initializer lists 2023-01-22 23:01:32 +01:00
Alexander Bock
45b1b9e7e7 Add tests for FileVerifier, DirectoryVerifier, and DateTimeVerifier (closes #1563) 2023-01-21 22:14:09 +01:00
Alexander Bock
4f4764209f Happy new year 2023-01-02 11:19:33 +01:00
GPayne
0e52b3debd Minor fix to ostest timestamps to avoid timing issue 2022-11-15 08:58:24 -07:00
GPayne
9aa229fd28 Minor fixes to image test scripts 2022-11-15 08:56:32 -07:00
Alexander Bock
6249fa6d89 Collection of a number of changes (#2286)
* Cleanup Property code
* Remove NOLINT statements
* Return Property class types as string_view
* Remove getStringValue function
* Simplify string value retrieval
* Ensure that image paths in the ImageSequenceTileProvider are sorted (closes #2205)
* Some cleanup of OpenSpaceEngine
* Cleanup documentation
* Some more cleanup of engine classes
* Some more cleanup
* Update SGCT repository
* Use new Jenkins node identifiers as the old method broke with update
2022-10-30 12:54:14 +01:00
Alexander Bock
aeb366ae61 Add new dashboard item to show elapsed times (closes #2234). Cleanup handling of TimeConversion and add unit testing 2022-10-15 00:08:22 +02:00
Alexander Bock
c1252902c7 More Code Cleanup (#2192)
* Harmonizing ( and ) in function calls
* static const -> constexpr
* Fix compile issue
* Unify shader tab size
* Add _fs and _vs to shaders
* Harmonize spacing
2022-07-26 11:22:41 +02:00
Alexander Bock
9cc4c595a8 Code Cleanup (#2191)
* constexpr const -> constexpr
* const char* -> std::string_view
2022-07-25 15:57:45 +02:00
Alexander Bock
10ec6d3013 Revert pragma warnings 2022-07-11 14:26:13 +02:00
Alexander Bock
0b62d5cc4b Disable unknown pragma warnings and adapt to it 2022-07-05 14:27:40 +02:00
Emma Broman
b0968392c5 Update ghoul to keep full precision when converting Lua value to string
And update tests that use the conversion

Fixes lost precision when printing navigation state from openspace.navigation.getNavigationState()
2022-07-04 16:28:14 +02:00
Malin E
71355637db Address PR comments 2022-06-30 14:13:03 +02:00
Malin E
186e0b9ced Adjust double comparison tests 2022-06-01 13:45:53 +02:00
Malin E
0c7cbea125 Adjust double comparisons in tests 2022-05-24 10:13:38 +02:00
Malin E
6eb732b9d0 Add tests for horizons feature 2022-05-24 09:34:25 +02:00
Alexander Bock
5751fe26d3 Cleanup handling of warnings (#2030) 2022-04-16 20:57:29 +02:00
Alexander Bock
3844df20c9 Feature/codegen lua (#1906)
Adapting Lua functions to new codegen functionality
Improve the documentation itself
Add some styling to generated documentation
Have parameter names for Lua-defined Lua function documentation

Co-authored-by: Emma Broman <emma.broman@liu.se>
2022-03-21 09:05:37 +01:00
Alexander Bock
cbe2e6cdcf Set the default window size to 66% of the primary window size (closes #1883) 2022-02-17 17:55:43 +01:00
Alexander Bock
e8072495ec Feature/warnings (#1885)
Remove many warnings from MSVC, Clang, and GCC
2022-02-16 18:33:12 +01:00
Alexander Bock
30212b6768 Adapt to new auto coding style 2022-02-10 15:20:21 +01:00
Alexander Bock
a7841ce405 Working unit tests (#1882)
* Enable all unit tests in Jenkins (closes #1666)
* Fix issue with Profile where the version number is not updated if the profile does not contain keybindings
* Fix issue with script schedule that would cause a crash when only one script is scheduled
* Fix test for colorimage, use correct path to unit test executable for non-windows platforms
* Provide stable class names for vector and matrix verifiers
2022-02-10 01:06:41 +01:00
Alexander Bock
0290bec7d0 Remove empty unit test 2022-01-01 22:41:21 +01:00
Alexander Bock
550faec8fb Fix example, don't store DefaultTileProvider as unique_ptrs 2022-01-01 13:07:15 +01:00
Alexander Bock
d7d279ea16 Happy new year 2022-01-01 12:32:55 +01:00
Alexander Bock
debcb43ade Feature/assets (#1784)
General overhaul of the Asset loading system
2021-12-19 18:04:01 +01:00
Emma Broman
57e662e8e2 Update a couple of broken tests 2021-12-06 13:47:29 +01:00
Emma Broman
59dc296cf1 Update ghoul to use new luaTableToString function
And update some tests based on the change
2021-12-06 13:21:39 +01:00
Malin E
d86923ebb7 Fix ScriptScheduler tests 2021-10-25 10:49:24 +02:00
Alexander Bock
db472030de GCC warnings (#1725) 2021-08-21 11:42:44 +02:00
Alexander Bock
34985f64a6 Feature/keybindings (#1708)
* Add action manager to handle actions in replacement of keyboard shortcuts
* Implement new Action concept
* Remove the shortcutscomponent as it is no longer needed
* Update profile version from 1.0 to 1.1
* Add action dialog
* Restructure of key specification in keys.h
* Remove solid field-of-view keybind from the newhorizons profile as the setting no longer exists
2021-08-18 10:58:20 +02:00
Emma Broman
bfe25c311b Merge branch 'master' into thesis/2019/camera-paths
# Conflicts:
#	src/rendering/abufferrenderer.cpp
2021-08-09 15:21:08 +02:00
Alexander Bock
dfca605d63 Add the optional ability to print a stacktrace with an OpenGL error (closes #1700) 2021-07-30 15:37:03 +02:00
Alexander Bock
90157ce463 Warnings and compile fixes for MSVC 2021-07-30 15:01:21 +02:00
Emma Broman
77bdfaefd6 Move camera path code into core and refactor navigation code a bit 2021-06-23 09:12:36 +02:00
Alexander Bock
92432caed2 Adapt to changes in Ghoul that made absPath return a std::filesystem::path instead of a std::string 2021-05-17 00:23:15 +02:00
Alexander Bock
ccdc5a5dc3 Feature/filesystem cleanup (#1587)
* Adapting to the changes in Ghoul
* First step of moving filesystem functions to std
* Remove persistence flag from cachemanager
2021-05-16 20:26:49 +02:00
Emma Broman
e6a7225028 Fix missed perSceneCache rename in test file 2021-05-06 15:24:35 +02:00
Emma Broman
804444e267 Simplify Property code (#1575)
* Remove the PropertyDelegate

* Remove some unused and redundant property types

* Use helper functions for Lua/Json conversion

* Solve a bug in SelectionProperty that occurred when re-setting options

* General simplification and refactoring of the code
2021-05-04 09:32:29 +02:00
GPayne
d47ac2f248 Added month of day limit for yearly increment 2021-05-03 15:18:16 -06:00
GPayne
6fc1d608e9 Fix that allows all days of month except monthly increment still at 1-28 2021-05-03 15:18:16 -06:00