* Make skybrowser use accelerated rendering
* Remove flag for not accelerating rendering
* Make default side full HD for texture
* Make wwt calls be exposed with pointer to worldwidetelescope communicator & restructure
* Restore on reload functionality
* Make default value for updating the sky browser when target travels true
* Remove texture quality property and make the vfov and radius work again
- bump CMAKE_OSX_DEPLOYMENT_TARGET to "13.3"
- CXX STANDARD to 20 etc for Mac builds
- Update cef platforms correctly for arm64 and x86_64
- patch cxx and c standard versions in flags set for macos
The OpenSpace_Helper process was staying when terminating OpenSpace. This fixes that by automatically closing the helper process when the parent process dies for whatever reasons
* Fix compile issue on Apple reg ALSA. since ALSA won't be available on Apple machines, we need to choose coreaudio instead.
* Changes for target without spaces. newer versions of CMake don't allow targets to have spaces, but we can specify TARGET_OUTPUT_NAME with spaces
According to https://github.com/chromiumembedded/cef/issues/3685, using
the so-called "Alloy bootstrap" (which seems to be the default) is
deprecated. This causes a warning when starting OpenSpace.
In some setups (e.g. an AppImage build on Ubuntu 22.04), the warning is
followed by a fatal error and a crash:
[0505/213642.653624:FATAL:path_service.cc(265)] Failed to get the path for 1001
Following the migration instructions from the aforementioned ticket
solve both the warning and the crash.
* Remove Escape keybind; move gui keybind to F2
* Clear up keybinds properly
* Workaround for CEF focus bug
* Add TODO comment
* Guard against null ptr dereferencing
* Remove shift tab
* add additional keyboard mapping from glfw to cef
* Change dashboards to make prototype for first user test
* add mission added/removed event, disptached when a mission has been loaded/unloaded
* send missions as map instaed of array, rename missionName -> name
* Set keybind for toggling overlays to shift+f2
* Remove property for showing the title in the gui skybrowser module
* Remove default setting for skybrowser
* First implementation of setting the ui panel visibility from the launcher
* Add profile topic
* Coding style adjustment
* Add markNodes to the profiletopic
* Change format of additional data of options in engine
* Address PR comments
* map escape key from glfw to cef correctly
* fix issue with "Enter" key not working on buttons and other input fields in CEF
* Add test for new profile version
* Send skybrowser data although we are outside the solar system
* Update webgui to new ui
* Add name to profile topic
* Add cef variable to javascript context for when browser is in cef
* Use camelcase for cef variable
* Rewrite shortcuts topic to ActionKeybind and pass data in a better way (#3590)
* Rewrite shortcuts topic to ActionKeybind and pass data in a better way
* Fix strange error with file structure
* Address PR comments
* Address PR comments
* Address PR comments
* Make numbers in asset file prettier
* Rename name to identifier for missions event
* Clean up browser code
* Update UI hash (to fix the actions panel not working)
And update outdated comment. The backend is not part of this
* Feature/notify meta data change (#3605)
* Add notifyMetaDataChangeListener to topic
* First round of clean up the data passing
* Convert from string to json for metadata
* Update additional data to json
* Use nlohmann::json for additional data
* Pass meta data in new structure to topics
* Remove meta data method
* Fix mistake in merge
* Update src/properties/property.cpp
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* remove TODO comment that will be fixed by this PR
* Address PR comments
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Emma Broman <emma.broman@liu.se>
* Address PR comment
* Remove function for setting the endpoint
* Update frontend hash
* Remove enabled property from exoplanets module
* Remove enabled property from skybrowser module
* Update default UI panels json
* Remove setting of enabled properties for skybrowser and exoplanets
* Update gui hash
* Auto format json
---------
Co-authored-by: Andreas Engberg <adde.engberg@gmail.com>
Co-authored-by: Emma Broman <emma.broman@liu.se>
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
Co-authored-by: Alexander Bock <mail@alexanderbock.eu>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Remove toStringConversion function and move json_helper include out of numericalproperty.inl
- Optimizing some header files
- Remove duplicate Lua functions from properties.
- Move List,Option,Selection,String, and TriggerProperty into misc folder
- Move lua_helper include out of inline file
- Add lua_helper to the precompiled header
- Declare property functions as final. No longer have OptionProperty derive from IntProperty
- Remove Dictionary header from properties
* Update CEF version number
* Set OpenSpace_Helper version of C++ to 20
* Update C++ syntax to v 20
* Remove deprecated function (now default)
* Set the cache folder for cef
* Make static function in webbrowsermodule that determines if we can use accelerated rendering
* Add flag for accelerated rendering to webrenderhandler
* Use accelerated rendering
* Implement function to see if gui should absorb click
* Adhere to 80 char linewidth
* Make only the UI GPU accelerated
* Use dirty rects size for the texture to remove crash
* Better comments
* Make has content function work for GPU acceleration
* Make it so all browsers can be accelerated
Tried making it so only the gui was accelerated for simplicity. Performance plummeted, so reverted that
* Tidy up
* Add accelerated rendering flag to the screenspacerenderable shader
* Add temporary fix to make the sky browser work
* Remove flag from gui render handler
* Enable webgl in a nicer way
* Unbind texture in screenspacerenderable
* Add better comments for error handling
* Tidy up
* Address PR comments
* Make the acceleration Windows only
* Remove unnecessary setting of shader dictionary
* Add display handler to browser client
* Make glfw change mouse cursor depending on cef cursor
* formatting
* Add switch to main
* Update modules/webbrowser/src/browserclient.cpp
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
* Address comments on PR
* Update again
* Update modules/webbrowser/src/browserclient.cpp
Co-authored-by: Emma Broman <emma.broman@liu.se>
* Address PR comments
---------
Co-authored-by: Ylva Selling <ylva.selling@liu.se>
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
Co-authored-by: Emma Broman <emma.broman@liu.se>
* Update CEF version number
* Set OpenSpace_Helper version of C++ to 20
* Update C++ syntax to v 20
* Remove deprecated function (now default)
* Set the cache folder for cef
* Make static function in webbrowsermodule that determines if we can use accelerated rendering
* Add flag for accelerated rendering to webrenderhandler
* Use accelerated rendering
* Implement function to see if gui should absorb click
* Adhere to 80 char linewidth
* Make only the UI GPU accelerated
* Use dirty rects size for the texture to remove crash
* Better comments
* Make has content function work for GPU acceleration
* Make it so all browsers can be accelerated
Tried making it so only the gui was accelerated for simplicity. Performance plummeted, so reverted that
* Tidy up
* Add accelerated rendering flag to the screenspacerenderable shader
* Add temporary fix to make the sky browser work
* Remove flag from gui render handler
* Enable webgl in a nicer way
* Unbind texture in screenspacerenderable
* Add better comments for error handling
* Tidy up
* Address PR comments
* Make the acceleration Windows only
* Remove unnecessary setting of shader dictionary
* Allow web dev tools to connect to CEF
* Update modules/webbrowser/include/browserinstance.h
Co-authored-by: Emma Broman <emma.broman@liu.se>
* Update modules/webbrowser/include/webrenderhandler.h
Co-authored-by: Emma Broman <emma.broman@liu.se>
* Apply suggestions from code review
Co-authored-by: Emma Broman <emma.broman@liu.se>
---------
Co-authored-by: Ylva Selling <ylva.selling@liu.se>
Co-authored-by: Emma Broman <emma.broman@liu.se>
* Update CEF version number
* Set OpenSpace_Helper version of C++ to 20
* Update C++ syntax to v 20
* Remove deprecated function (now default)
* Set the cache folder for cef
* Update modules/webbrowser/src/cefhost.cpp
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
* Update version number
---------
Co-authored-by: Ylva Selling <ylva.selling@liu.se>
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
* Apply the hue, value, saturation, and gamma values from the renderengine to screenspace renderables. Change the screenspace's own gamma value into an offset
* Make it clearer that the gamma correction is now an offset
