Remove more warnings from the codebase

apps/DocsWriter/main.cpp

@@ -31,7 +31,7 @@
 #include <ghoul/ghoul.h>
 #include <ghoul/logging/logmanager.h>
 
-int main(int argc, char** argv) {
+int main(int, char** argv) {
     using namespace openspace;
 
     ghoul::logging::LogManager::initialize(

modules/base/rendering/renderableplane.cpp

@@ -238,12 +238,12 @@ RenderablePlane::DistanceScalingSettings::DistanceScalingSettings(
 RenderablePlane::RenderablePlane(const ghoul::Dictionary& dictionary)
     : Renderable(dictionary, { .automaticallyUpdateRenderBin = false })
     , _blendMode(BlendModeInfo)
-    , _distanceScalingSettings(dictionary)
     , _renderOption(OrientationRenderOptionInfo)
     , _mirrorBackside(MirrorBacksideInfo, false)
     , _size(SizeInfo, glm::vec2(10.f), glm::vec2(0.f), glm::vec2(1e25f))
     , _autoScale(AutoScaleInfo, false)
     , _multiplyColor(MultiplyColorInfo, glm::vec3(1.f), glm::vec3(0.f), glm::vec3(1.f))
+    , _distanceScalingSettings(dictionary)
 {
     const Parameters p = codegen::bake<Parameters>(dictionary);
 

modules/telemetry/src/general/nodestelemetry_lua.inl

@@ -44,7 +44,7 @@ namespace {
     }
 
     openspace::NodesTelemetry* nodesTelemetry =
-        reinterpret_cast<openspace::NodesTelemetry*>(ptr);
+        dynamic_cast<openspace::NodesTelemetry*>(ptr);
 
     for (const std::string_view& k : nodes.keys()) {
         std::string node = nodes.value<std::string>(k);

modules/telemetry/src/general/timetelemetry.cpp

@@ -76,7 +76,7 @@ TimeTelemetry::TimeTelemetry(const std::string& ip, int port)
     , _precisionProperties(TimeTelemetry::PrecisionProperties(PrecisionInfo))
 {
     for (size_t i = 0; i < TimeUnitNames.size(); ++i) {
-        _timeUnitOption.addOption(i, TimeUnitNames[i].singular.data());
+        _timeUnitOption.addOption(static_cast<int>(i), TimeUnitNames[i].singular.data());
     }
 
     _timeUnitOption.setValue(static_cast<int>(TimeUnit::Day));

modules/telemetry/src/specific/planetsoverviewsonification.cpp

@@ -28,8 +28,6 @@
 #include <openspace/util/memorymanager.h>
 
 namespace {
-    constexpr std::string_view _loggerCat = "PlanetsOverviewSonification";
-
     // Indices for data items
     constexpr int NumDataItems = 1;
     constexpr int GuiSettingsIndex = 0;

modules/telemetry/src/telemetrybase.cpp

@@ -30,14 +30,11 @@
 #include <openspace/query/query.h>
 
 namespace {
-    constexpr std::string_view _loggerCat = "TelemetryBase";
-
     constexpr openspace::properties::Property::PropertyInfo EnabledInfo = {
         "Enabled",
         "Enabled",
         "This setting determines whether this telemetry gathering is enabled or not.",
         openspace::properties::Property::Visibility::User
-
     };
 } // namespace
 
@@ -46,8 +43,8 @@ namespace openspace {
 TelemetryBase::TelemetryBase(properties::PropertyOwner::PropertyOwnerInfo info,
                              const std::string& ip, int port)
     : properties::PropertyOwner(info)
-    , _enabled(EnabledInfo, false)
     , _identifier(info.identifier)
+    , _enabled(EnabledInfo, false)
     , _connection(new OpenSoundControlConnection(ip, port))
 {
     addProperty(_enabled);

modules/telemetry/telemetrymodule.cpp

@@ -43,8 +43,6 @@
 #include <ghoul/logging/logmanager.h>
 
 namespace {
-    constexpr std::string_view _loggerCat = "TelemetryModule";
-
     // The default Open Sound Control receiver is SuperCollider with these default values.
     // However, the user can define any receiver in the openspace.cfg file as the
     // ModuleConfiguration for the Telemetry module.

modules/webbrowser/src/webrenderhandler.cpp

@@ -112,7 +112,7 @@ void WebRenderHandler::OnPaint(CefRefPtr<CefBrowser>, CefRenderHandler::PaintEle
 }
 
 #ifdef WIN32
-void WebRenderHandler::OnAcceleratedPaint(CefRefPtr<CefBrowser> browser,
+void WebRenderHandler::OnAcceleratedPaint(CefRefPtr<CefBrowser>,
                                           PaintElementType,
                                           const RectList& dirtyRects,
                                           const CefAcceleratedPaintInfo& info)