mirror/QuickStack
1
0
Fork 0
mirror of https://github.com/biersoeckli/QuickStack.git synced 2026-02-11 05:59:23 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix: add delay before deleting log files to ensure they are fully written

Browse Source
This commit is contained in:
biersoeckli
2025-02-01 16:45:39 +00:00
parent 6ca354e0fc
commit 84e2fccf25
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/server/services/standalone-services/app-logs.service.ts
View File

@@ -119,29 +119,30 @@ class AppLogsService {
let logPathsWritten = [];
for (const pod of podInfos) {
const logPath = await this.writeLogsToFileForPod(pod, app, startOfDay, secondsSinceMidnight);
logPathsWritten.push(logPath);
if (await FsUtils.fileExists(logPath)) {
logPathsWritten.push(logPath);
} else {
console.error(`Error writing logs to file for pod ${pod.podName} in app ${app.id}. There was no file written!`);
}
}
// create tar.gz file from all log files
const logFilePath = PathUtils.appLogsFile(app.id, startOfDay);
await FsUtils.deleteFileIfExists(logFilePath); // delete existing log file --> new one will be created
/*
// this doesn't work, because it doesn't wait for the file to be written
await create({
gzip: true,
file: logFilePath,
cwd: PathUtils.appLogsFolder(app.id)
}, logPathsWritten);
*/
await CommandExecutorUtils.runCommand(`tar -czf ${logFilePath} ${logPathsWritten.join(' ')}`);
if (!FsUtils.fileExists(logFilePath)) {
throw new Error(`Error creating tar file for logs of app ${app.id} on path ${logFilePath}`);
}
for (const logPath of logPathsWritten) {
await FsUtils.deleteFileIfExists(logPath);
//await FsUtils.deleteFileIfExists(logPath);
}
return {
@@ -178,7 +179,7 @@ class AppLogsService {
});
logStream.on('error', (error) => {
console.error("Error in log stream:", error);
console.error(`Error fetching logs for pod ${pod.podName} in container ${pod.containerName}`, error);
reject(error);
});
@@ -188,6 +189,7 @@ class AppLogsService {
requestWebSocket?.abort();
});
} catch (error) {
console.error(`Error fetching logs for pod ${pod.podName} in container ${pod.containerName}`, error);
reject(error);
}
});