mirror/UNIT3D-Community-Edition
1
0
Fork 0
mirror of https://github.com/HDInnovations/UNIT3D-Community-Edition.git synced 2026-04-22 01:38:49 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: don't use unnecessary orderByRaw

Browse Source 
Null values are always ordered last anyways. Additionally, count(*) returns 0, not null. Also fixes issue on mariadb with value being a reserved keyword.
This commit is contained in:
Roardom
2025-02-11 06:24:21 +00:00
parent e45231b124
commit 5e8f54fa4c
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Http/Livewire/TopUsers.php
+3 -3
View File
@@ -139,7 +139,7 @@ class TopUsers extends Component
->where('user_id', '!=', User::SYSTEM_USER_ID)
->where('anon', '=', false)
->groupBy('user_id')
->orderByRaw('COALESCE(value, 0) DESC')
->orderByDesc('value')
->take(8)
->get();
}
@@ -154,7 +154,7 @@ class TopUsers extends Component
->select(DB::raw('user_id, COUNT(user_id) as value'))
->where('user_id', '!=', User::SYSTEM_USER_ID)
->groupBy('user_id')
->orderByRaw('COALESCE(value, 0) DESC')
->orderByDesc('value')
->take(8)
->get();
}
@@ -169,7 +169,7 @@ class TopUsers extends Component
->select(DB::raw('user_id, COUNT(user_id) as value'))
->where('user_id', '!=', User::SYSTEM_USER_ID)
->groupBy('user_id')
->orderByRaw('COALESCE(value, 0) DESC')
->orderByDesc('value')
->take(8)
->get();
}