mirror/api
1
0
Fork 0
mirror of https://github.com/unraid/api.git synced 2026-01-04 07:29:48 -06:00
Code Issues Packages Projects Releases Wiki Activity

refactor(NotificationService): replace removeFromOverview

Browse Source 
with `decrement` & `publishOverview`
This commit is contained in:
Pujit Mehrotra
2024-09-30 13:35:42 -04:00
parent f20349fb2a
commit 0c627d1ade
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
api/src/unraid-api/graph/resolvers/notifications/notifications.service.ts
View File

@@ -104,14 +104,6 @@ export class NotificationsService {
});
}
private async removeFromOverview(notification: Notification) {
const { type, id, importance } = notification;
this.logger.debug(`Removing ${type} Notification: ${id}`);
this.decrement(importance, NotificationsService.overview[type.toLowerCase()]);
return this.publishOverview();
}
/**
* Returns a stable snapshot of the current notification overview.
*
@@ -216,7 +208,9 @@ export class NotificationsService {
const notification = await this.loadNotificationFile(path, type);
await unlink(path);
await this.removeFromOverview(notification);
this.decrement(notification.importance, NotificationsService.overview[type.toLowerCase()]);
await this.publishOverview();
// return both the overview & the deleted notification
// this helps us reference the deleted notification in-memory if we want