mirror/api
1
0
Fork 0
mirror of https://github.com/unraid/api.git synced 2026-01-01 06:01:18 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(plugin): flaky masking of benign warning during pnpm install (#1313)

Browse Source 
The masking logic has a different effect in TTY and non-TTY environments
bc pnpm will change the `install` reporter. Now, we:

- set `--reporter=append-only` for consistency
- replace the grep loop with `sed` to mask and redirect the benign
"Ignored build scripts" warning

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Streamlined the background logging during dependency installations to
improve overall efficiency and reduce complexity. This update enhances
maintainability without any visible changes to the user experience.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
Pujit Mehrotra
2025-04-03 09:20:55 -04:00
committed by GitHub
parent df168224ea
commit 1f10b63c8b
1 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
plugin/source/dynamix.unraid.net/etc/rc.d/rc.unraid-api
View File

@@ -108,16 +108,8 @@ restore_pnpm_store() {
# Output: Streams install progress and logs build script warnings # Output: Streams install progress and logs build script warnings
run_pnpm_install() { run_pnpm_install() {
local log_file="/var/log/unraid-api/build-scripts.log" local log_file="/var/log/unraid-api/build-scripts.log"
stdbuf -oL pnpm install --prod --prefer-offline 2>&1 | while IFS= read -r line; do stdbuf -oL pnpm install --prod --prefer-offline --reporter=append-only 2>&1 | sed -e "/^╭ Warning/,/^╰/w $log_file" -e "/^╭ Warning/,/^╰/c\Build scripts completed. See $log_file for details."
if echo "$line" | grep -q "Ignored build scripts:"; then echo "Note: This warning is expected. Build scripts are intentionally ignored for security and performance reasons." >> "$log_file"
mkdir -p "$(dirname "$log_file")"
echo "Note: This warning is expected. Build scripts are intentionally ignored for security and performance reasons." > "$log_file"
echo "$line" >> "$log_file"
echo "Build scripts completed. See $log_file for details."
else
echo "$line"
fi
done
} }
# Installs production dependencies for the unraid-api using pnpm. Prefers offline mode. # Installs production dependencies for the unraid-api using pnpm. Prefers offline mode.