Add deprecation warnings for server args

This commit is contained in:
Isaac Murchie
2014-08-20 08:16:05 -07:00
parent 07eac83e3d
commit 8cdee8e25e
2 changed files with 15 additions and 0 deletions

View File

@@ -197,6 +197,16 @@ var getNonDefaultArgs = function (parser, args) {
return nonDefaults;
};
var getDeprecatedArgs = function (parser) {
var deprecated = {};
_.each(parser.rawArgs, function (rawArg) {
if (rawArg[1].deprecatedFor) {
deprecated[rawArg[0]] = "use instead: " + rawArg[1].deprecatedFor;
}
});
return deprecated;
};
module.exports.startListening = function (server, args, parser, appiumVer, appiumRev, appiumServer, cb) {
var alreadyReturned = false;
server.listen(args.port, args.address, function () {
@@ -216,6 +226,10 @@ module.exports.startListening = function (server, args, parser, appiumVer, appiu
if (_.size(showArgs)) {
logger.debug("Non-default server args: " + JSON.stringify(showArgs));
}
var deprecatedArgs = getDeprecatedArgs(parser);
if (_.size(deprecatedArgs)) {
logger.warn("Deprecated server args: " + JSON.stringify(deprecatedArgs));
}
logger.info('LogLevel:', logger.appiumLoglevel);
});
server.on('error', function (err) {

View File

@@ -407,6 +407,7 @@ var args = [
, dest: 'showSimulatorLog'
, action: 'storeTrue'
, required: false
, deprecatedFor: '--show-ios-log'
, help: "(IOS-only) if set, the iOS simulator log will be written to the console"
, nargs: 0
}],