mirror/appium
1
0
Fork 0
mirror of https://github.com/appium/appium.git synced 2026-02-13 21:39:49 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5770 from jlipps/1.5

Browse Source 
don't let getDriverForCaps blow up mysteriously on forgotten platformName
This commit is contained in:
Isaac A. Murchie
2015-10-28 08:32:25 -07:00
parent 2c87a61a3e 64d36041a9
commit cd07216fb6
2 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/appium.js
View File

@@ -28,6 +28,10 @@ class AppiumDriver extends BaseDriver {
getDriverForCaps (caps) {
// TODO if this logic ever becomes complex, should probably factor out
// into its own file
if (!caps.platformName || !_.isString(caps.platformName)) {
throw new Error("You must include a platformName capability");
}
if (caps.platformName.toLowerCase() === "fake") {
return FakeDriver;
}
@@ -39,7 +43,8 @@ class AppiumDriver extends BaseDriver {
if (caps.platformName.toLowerCase() === 'ios') {
return IosDriver;
}
throw new Error("Could not find a driver for those caps");
throw new Error("Could not find a driver for those caps. Please double-" +
"check your platformName capability");
}
async getStatus () {

6
test/driver-specs.js
View File

@@ -123,5 +123,11 @@ describe('AppiumDriver', () => {
});
describe('sessionExists', () => {
});
describe('getDriverForCaps', () => {
it('should not blow up if user doesnt provide platformName', () => {
let appium = new AppiumDriver({});
(() => { appium.getDriverForCaps({}); }).should.throw(/platformName/);
});
});
});
});