mirror/bugsink
1
0
Fork 0
mirror of https://github.com/bugsink/bugsink.git synced 2025-12-30 18:00:17 -06:00
Code Issues Packages Projects Releases Wiki Activity

Comment about FileNotError

Browse Source
This commit is contained in:
Klaas van Schelven
2025-10-27 21:53:31 +01:00
parent 8ad7f97380
commit 20e065c6e8
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
ingest/tasks.py
View File

@@ -23,4 +23,11 @@ def digest(event_id, event_metadata):
except ValidationError as e:
logger.warning("ValidationError in digest_event", exc_info=e)
finally:
# NOTE: if an SDK misbehaves, and sends the same event_id multiple times in quick succession, the line below
# will trigger a FileNotFoundError on the second attempt to delete the file (the files also overwrite each other
# on-ingest). In that case your logs will also a "ValidationError in digest_event". Although that means an error
# bubbles up from the below, at least for now I'm OK with that. (next steps _could_ be: [a] catching the error
# as expected [b] refusing to "just overwrite and doubly enqueue on-ingest" [c] reporting about this particular
# problem to the end-user etc... but at least "getting it really right" might actually be quite hard (race
# conditions) and I'm not so sure it's worth it.
os.unlink(get_filename_for_event_id(event_id))