Rename Dockerfile to Dockerfile.fromwheel

See #68 for discussion (which is summarized at the top of the Dockerfile)
This commit is contained in:
Klaas van Schelven
2025-04-04 11:41:45 +02:00
parent f19d9eda4d
commit 786a97aaa0
3 changed files with 14 additions and 2 deletions

View File

@@ -1,3 +1,15 @@
# This is the Dockerfile that builds an image given a specified WHEEL_FILE,
# rather than from source/working dir.
#
# The reason for this is that, although Bugsink is certainly available as a
# Docker image, it is available as a Python package first. We thus want
# the Docker image to be as faithful as possible to the Python package.
#
# Because the typical expectation for a Dockerfile is that it "just works"
# and that it builds from source (the working directory), the present file
# is not named Dockerfile, but an explicitly postfixed one. Still, for the
# purpose of what actually ends up on Docker hub, the present file is the
# one that's used.
ARG PYTHON_VERSION=3.12
# Build image: non-slim, in particular to build the mysqlclient wheel

View File

@@ -26,4 +26,4 @@ else
fi
docker build --build-arg WHEEL_FILE=$WHEEL_FILE $TAGS .
docker build -f Dockerfile.fromwheel --build-arg WHEEL_FILE=$WHEEL_FILE $TAGS .

View File

@@ -26,4 +26,4 @@ else
fi
docker buildx build --platform linux/amd64,linux/arm64 --build-arg WHEEL_FILE=$WHEEL_FILE $TAGS . --push
docker buildx build -f Dockerfile.fromwheel --platform linux/amd64,linux/arm64 --build-arg WHEEL_FILE=$WHEEL_FILE $TAGS . --push