mirror/bugsink
1
0
Fork 0
mirror of https://github.com/bugsink/bugsink.git synced 2026-01-06 05:10:15 -06:00
Code Issues Packages Projects Releases Wiki Activity

For log messages, demote the msg into the value

Browse Source 
and make the type 'Log Message'.
This may just be a matter of personal taste, but I've always found these
messages-as-type super-confusing. I'd rather have some made up (but clear,
and thanks to the whitespace unlikely-to-otherwise-exist) type "Log Message".

This is also inline in what I've already done in the UI.
This commit is contained in:
Klaas van Schelven
2024-04-08 14:47:32 +02:00
parent a70ac7e1cb
commit 8d17e7b128
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
issues/tests.py
View File

@@ -532,21 +532,21 @@ class IntegrationTest(DjangoTestCase):
class GroupingUtilsTestCase(DjangoTestCase):
def test_empty_data(self):
self.assertEquals("<unlabeled event> ⋄ ⋄ DefaultEvent", get_issue_grouper_for_data({}))
self.assertEquals("Log Message: <no log message> ⋄ ⋄ DefaultEvent", get_issue_grouper_for_data({}))
def test_logentry_message_takes_precedence(self):
self.assertEquals("msg: ? ⋄ ⋄ DefaultEvent", get_issue_grouper_for_data({"logentry": {
self.assertEquals("Log Message: msg: ? ⋄ ⋄ DefaultEvent", get_issue_grouper_for_data({"logentry": {
"message": "msg: ?",
"formatted": "msg: foobar",
}}))
def test_logentry_with_formatted_only(self):
self.assertEquals("msg: foobar ⋄ ⋄ DefaultEvent", get_issue_grouper_for_data({"logentry": {
self.assertEquals("Log Message: msg: foobar ⋄ ⋄ DefaultEvent", get_issue_grouper_for_data({"logentry": {
"formatted": "msg: foobar",
}}))
def test_logentry_with_transaction(self):
self.assertEquals("msg ⋄ transaction ⋄ DefaultEvent", get_issue_grouper_for_data({
self.assertEquals("Log Message: msg ⋄ transaction ⋄ DefaultEvent", get_issue_grouper_for_data({
"logentry": {
"message": "msg",
},
@@ -646,6 +646,6 @@ class GroupingUtilsTestCase(DjangoTestCase):
self.assertEquals("fixed string", get_issue_grouper_for_data({"fingerprint": ["fixed string"]}))
def test_fingerprint_with_default(self):
self.assertEquals("<unlabeled event> ⋄ ⋄ DefaultEvent ⋄ fixed string", get_issue_grouper_for_data({
self.assertEquals("Log Message: <no log message> ⋄ ⋄ DefaultEvent ⋄ fixed string", get_issue_grouper_for_data({
"fingerprint": ["{{ default }}", "fixed string"],
}))

4
sentry/eventtypes/base.py
View File

@@ -15,6 +15,6 @@ class DefaultEvent:
)
if message:
return truncatechars(message.splitlines()[0], 100), ""
return "Log Message", truncatechars(message.splitlines()[0], 100)
return "<unlabeled event>", ""
return "Log Message", "<no log message>"