mirror/bugsink
1
0
Fork 0
mirror of https://github.com/bugsink/bugsink.git synced 2026-01-05 12:50:17 -06:00
Code Issues Packages Projects Releases Wiki Activity

Do not allow immediate_atomic to run in non-Transactional testcase

Browse Source
This commit is contained in:
Klaas van Schelven
2024-04-26 13:40:19 +02:00
parent 6b5ed1268a
commit c8053bfec4
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
bugsink/transaction.py
View File

@@ -60,6 +60,17 @@ class ImmediateAtomic(django_db_transaction.Atomic):
def __enter__(self):
connection = django_db_transaction.get_connection(self.using)
# Like the superclass check, but more strict for the case of "in tests"
if (self.durable and connection.atomic_blocks):
if not connection.atomic_blocks[-1]._from_testcase:
raise RuntimeError("A durable atomic block cannot be nested within another atomic block.")
# We do not allow nesting of durable atomic blocks in tests. If it's important enough to run in atomic mode,
# it's important enough to be tested as such. I just spent 2 hours debugging a test that was failing because
# of this.
raise RuntimeError("A durable atomic block cannot be nested -- not even in tests.")
if hasattr(connection, "_start_transaction_under_autocommit"):
connection._start_transaction_under_autocommit_original = connection._start_transaction_under_autocommit
connection._start_transaction_under_autocommit = types.MethodType(