mirror/bugsink
1
0
Fork 0
mirror of https://github.com/bugsink/bugsink.git synced 2026-02-21 22:09:21 -06:00
Code Issues Packages Projects Releases Wiki Activity

Remove various non-TODOs

Browse Source 
either already done, or more of a 'this is a way this code could potentially
evolve in the future' (but not a 'we must do this')
This commit is contained in:
Klaas van Schelven
2024-09-13 10:05:22 +02:00
parent 79c9413256
commit eec8d51491
6 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
events/retention_simulator.py
View File

@@ -125,7 +125,7 @@ def main():
if this_how_many:
how_many = int(this_how_many)
# TODO the simulator does one cleanup per epoch, but the real thing does it on-demand as the max size is reached
# NOTE the simulator does one cleanup per epoch, but the real thing does it on-demand as the max size is reached
# For now I'm not updating the simulator, because I have the real thing to play around with.
print("INFLOW (with max %s)\n" % current_max_total_irrelevance)
simulate_epoch(epoch, how_many, current_max_total_irrelevance)

6
ingest/filestore.py
View File

@@ -3,8 +3,8 @@ from bugsink.app_settings import get_settings
def get_filename_for_event_id(event_id):
# TODO: the idea of having some levels of directories here (to avoid too many files in a single dir) is not yet
# implemented. Counterpoint: when doing stress tests, it was quite hard to get a serious backlog going (snappea was
# very well able to play catch-up). So this might not be necessary.
# The idea of having some levels of directories here (to avoid too many files in a single dir) is not yet
# implemented. However, counterpoint: when doing stress tests, it was quite hard to get a serious backlog going
# (snappea was very well able to play catch-up). So this might not be necessary.
return os.path.join(get_settings().INGEST_STORE_BASE_DIR, event_id)

4
ingest/management/commands/send_json.py
View File

@@ -127,7 +127,9 @@ class Command(BaseCommand):
headers = {
"Content-Type": "application/json",
"X-Sentry-Auth": get_header_value(dsn),
"X-BugSink-DebugInfo": identifier, # TODO do we want to send non-filename identifiers too?
# as it stands we always send identifier here, even if it's not a filename. Whether that's useful or
# annoying is an open question, but no reason to change it for now
"X-BugSink-DebugInfo": identifier,
}
data_bytes = json.dumps(data).encode("utf-8")
if use_envelope:

3
ingest/views.py
View File

@@ -2,7 +2,7 @@ import os
import logging
import io
from datetime import datetime, timezone
import json # TODO consider faster APIs
import json
from django.shortcuts import get_object_or_404
from django.db.models import Max
@@ -411,7 +411,6 @@ class IngestEnvelopeAPIView(BaseIngestAPIView):
else:
project = self.get_project_for_request(project_pk, request)
# TODO note not a problem
if project.quota_exceeded_until is not None and ingested_at < project.quota_exceeded_until:
# Sentry has x-sentry-rate-limits, but for now 429 is just fine. Client-side this is implemented as a 60s
# backoff.

2
issues/templates/issues/issue_list.html
View File

@@ -118,7 +118,7 @@
{% endspaceless %}
{# TODO "reopen" ... we don't do that currently, see notes in issue_detail #}
{# NOTE: "reopen" is not available in the UI as per the notes in issue_detail #}
{# only for resolved/muted items <button class="font-bold text-slate-500 border-slate-300 pl-4 pr-4 pb-2 pt-2 ml-1 border-2 hover:bg-slate-200 active:ring rounded-md">Reopen</button> #}
</div>

2
teams/models.py
View File

@@ -36,7 +36,7 @@ class TeamMembership(models.Model):
team = models.ForeignKey(Team, on_delete=models.CASCADE)
user = models.ForeignKey(settings.AUTH_USER_MODEL, on_delete=models.CASCADE)
send_email_alerts = models.BooleanField(default=None, null=True, blank=True) # TODO implement the associated logic
send_email_alerts = models.BooleanField(default=None, null=True, blank=True)
role = models.IntegerField(choices=TeamRole.choices, default=TeamRole.MEMBER)
accepted = models.BooleanField(default=False)