mirror/bugsink
1
0
Fork 0
mirror of https://github.com/bugsink/bugsink.git synced 2026-02-19 21:09:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

Remove copilot's overuse of comments / fallbacks

Browse Source
This commit is contained in:
Klaas van Schelven
2025-07-28 21:53:30 +02:00
parent e6c8c694bd
commit fe343f0749
1 changed files with 4 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
alerts/service_backends/slack.py
View File

@@ -126,21 +126,14 @@ def slack_backend_send_test_message(webhook_url, project_name, display_name, ser
)
result.raise_for_status()
# Success - clear any previous failure status
_store_success_info(service_config_id)
except requests.RequestException as e:
# Store failure information for requests-related errors
# For HTTPError from raise_for_status(), the response is in the exception
response = getattr(e, 'response', None)
if response is None and 'result' in locals():
# Fallback: if no response in exception, try to get it from the result
response = result
_store_failure_info(service_config_id, e, response)
raise
except Exception as e:
# Store failure information for other errors
_store_failure_info(service_config_id, e)
raise
@@ -213,21 +206,14 @@ def slack_backend_send_alert(
)
result.raise_for_status()
# Success - clear any previous failure status
_store_success_info(service_config_id)
except requests.RequestException as e:
# Store failure information for requests-related errors
# For HTTPError from raise_for_status(), the response is in the exception
response = getattr(e, 'response', None)
if response is None and 'result' in locals():
# Fallback: if no response in exception, try to get it from the result
response = result
_store_failure_info(service_config_id, e, response)
raise
except Exception as e:
# Store failure information for other errors
_store_failure_info(service_config_id, e)
raise