Klaas van Schelven
f236dea0bf
Don't allow newly created empty comments
2024-04-15 19:47:30 +02:00
Klaas van Schelven
a5f6326d26
Implement ctrl-enter form-submitting for the history comments
2024-04-15 19:43:18 +02:00
Klaas van Schelven
c3f8996e6b
History view: Make button stand out less
2024-04-15 19:33:08 +02:00
Klaas van Schelven
308a257d3f
Implement comment-deleting
2024-04-15 16:02:03 +02:00
Klaas van Schelven
d3e73a5c87
Permission-check on comment-editing
2024-04-15 15:12:43 +02:00
Klaas van Schelven
8db44bbb6d
Fix ResponseNotAllowed usage
...
not sure if this is 'a keeper' but let's at least use the right syntax
2024-04-15 15:10:21 +02:00
Klaas van Schelven
875f306079
Reduce queries of 'history' view
...
* select_related for users (which are displayed in many locations)
* use 'xxx_id' if that's all you need
2024-04-15 15:06:27 +02:00
Klaas van Schelven
132d06bf49
Fix csrf_token (it was outside form)
2024-04-15 14:56:34 +02:00
Klaas van Schelven
c3b2fc76bc
History-edit: smaller pencil icon, next to your name
2024-04-15 14:02:44 +02:00
Klaas van Schelven
17ace382dc
History: anchors for comments
2024-04-15 13:53:34 +02:00
Klaas van Schelven
6b23b03a82
History: edit (and fixes)
2024-04-15 13:44:14 +02:00
Klaas van Schelven
26aac0ca2c
Manual annotations: create 'm
...
and some non-completed code for editing
2024-04-15 12:58:50 +02:00
Klaas van Schelven
dcd154f74d
History: link to triggering event when it is available
2024-04-15 10:46:23 +02:00
Klaas van Schelven
f67d544c8d
Textual: System -> Bugsink
2024-04-15 10:26:19 +02:00
Klaas van Schelven
8e44f7f68e
Unmute reason: show in email alert
2024-04-15 10:17:18 +02:00
Klaas van Schelven
ad93e22fff
Fix the double-creating of TurningPoints for time-based-unmute
2024-04-15 09:55:22 +02:00
Klaas van Schelven
490899975b
Add tests for TurningPoint creation
...
this also proves one existing bug: the double-creating of TurningPoints
for time-based-unmute
2024-04-15 09:51:30 +02:00
Klaas van Schelven
2c4e8b9f20
Regular v.s. Django Testcase: be explicit
...
I recently ran into a funny issue where the TestCases were influencing my
development DB's contents
2024-04-15 09:17:53 +02:00
Klaas van Schelven
280bd2172b
History page: 'mostly done' (a first setup)
2024-04-12 16:07:25 +02:00
Klaas van Schelven
a9557201b1
Fix _is_valid_action 'typo'
2024-04-12 11:34:12 +02:00
Klaas van Schelven
1cf19c83d5
Various code-clarification
2024-04-12 08:38:46 +02:00
Klaas van Schelven
47e8318177
Remove event-list from issue tabs
...
at least postponed for now: we can navigate between events with the arrows,
and if we want more advanced ways of reaching particular events we may end
up implementing that using the more general 'search' interface
2024-04-11 11:23:08 +02:00
Klaas van Schelven
d2a17912d2
Rename templates for brevity
2024-04-10 12:01:01 +02:00
Klaas van Schelven
9d9f3816e3
Show 'logger' if this info is available
...
Somewhat untested, we used to have this in a very early version ("Emitted by")
and it was removed when converting into the calculated_xx style. I haven't found
any recent sample events that have this value but according to the spec it can
exist so I'm putting it back in.
2024-04-10 09:24:53 +02:00
Klaas van Schelven
13445324b8
Dead code removal
...
we do the whole of the 'log entry' stuff using the calculated_type and _value now
2024-04-10 09:20:46 +02:00
Klaas van Schelven
4dfefec468
denormalize/cache last_frame_* and transaction on Event and Issue
...
for performance, but also fixes:
* not just the 'last frame' but the 'last relevant frame' (in-app)
* truncation is properly done (matching the DB size, and for each of the fields)
2024-04-10 09:12:15 +02:00
Klaas van Schelven
b5babbda84
Event: urls match on external (sdk) event_id too
2024-04-09 12:37:25 +02:00
Klaas van Schelven
d46cb7f6e8
DB: unique_together and PositiveIntegerField
2024-04-09 12:34:29 +02:00
Klaas van Schelven
21c4904524
Implement friendly_id
2024-04-09 11:09:31 +02:00
Klaas van Schelven
72b65f73e4
Shift tabs around
...
Breadcrumbs left. Reasoning: it's an event-based page, should go with the others.
(Counterarg being: I dislike breadcrumbs)
History right. Having the historic view be the right-most "just feels right"
2024-04-09 09:43:35 +02:00
Klaas van Schelven
82b8c014e7
Add title to event-details
2024-04-09 09:39:50 +02:00
Klaas van Schelven
e9d5913c17
Event details: IDs and timestamps
2024-04-09 09:28:23 +02:00
Klaas van Schelven
1b37298a95
ingest_order: first setup
2024-04-08 22:13:52 +02:00
Klaas van Schelven
6d4b1beae4
Remove TODOs
2024-04-08 16:47:09 +02:00
Klaas van Schelven
f8d9aa736d
Push 'get_title' into default_issue_grouper
...
this is in prepartion of an expected future where we allow for more customization
of the grouping behavior
2024-04-08 16:30:11 +02:00
Klaas van Schelven
4016f13c07
Move truncatechars to the only place we actually need it
...
i.e. when storing stuff in the DB (other cases are taken care of on-render
2024-04-08 16:22:00 +02:00
Klaas van Schelven
da3f0325a2
Grouping: expose the recent data-modelling work in the UI
2024-04-08 16:17:45 +02:00
Klaas van Schelven
e98dddf2c4
Use a denormalized field (event_count) in the admin that's been available for a while
2024-04-08 15:34:28 +02:00
Klaas van Schelven
cc3a119998
Remove TODO; I stopped doubting (for now)
...
issue.title is based on the first event, but if this ever becomes a problem
I should probably deal with it by making issue.title better (generic over the
events or even editable) and not by making an issue-page which changes its
display based on which event is selected
2024-04-08 15:33:07 +02:00
Klaas van Schelven
652823f8c3
Store calculated type and value on issue and event and use these values in the templates
2024-04-08 15:30:41 +02:00
Klaas van Schelven
729a4c7ea1
Make <no transaction> explicit;
...
and more moving-around-of-code in preparation for our next step
2024-04-08 15:03:02 +02:00
Klaas van Schelven
cb75d318af
Remove the event_type_name from the grouper
...
it adds very little, especially now that we've put this information in the type
('Log Message') and removing this allows us to refactor more freely
2024-04-08 14:52:09 +02:00
Klaas van Schelven
8d17e7b128
For log messages, demote the msg into the value
...
and make the type 'Log Message'.
This may just be a matter of personal taste, but I've always found these
messages-as-type super-confusing. I'd rather have some made up (but clear,
and thanks to the whitespace unlikely-to-otherwise-exist) type "Log Message".
This is also inline in what I've already done in the UI.
2024-04-08 14:48:39 +02:00
Klaas van Schelven
a70ac7e1cb
Factor out the idea (exception -> type_, value) what we have
2024-04-08 14:39:14 +02:00
Klaas van Schelven
48307daa0f
Introduce 'Grouping' data-modeling
2024-04-08 11:41:15 +02:00
Klaas van Schelven
9dfae5a829
Use the diamond-separator when generating fingerprint-based groupers too
2024-04-05 15:41:12 +02:00
Klaas van Schelven
54e8009e73
Reorganize/cleanup title-generating code for clarification
2024-04-05 15:37:24 +02:00
Klaas van Schelven
80919d01b8
Remove the concept of 'culprit' from the grouping code
...
This has been deprecated in Sentry in 2016; no reason for us to support it.
It is noted that despite the deprecation (in favor of `transaction`) an
explicitly provided culprit actually took a higher precedence than an
explicitly provided transaction in the now-removed code.
2024-04-05 15:02:56 +02:00
Klaas van Schelven
eaa5ee6838
Tests for existing grouping functionality
2024-04-05 12:10:51 +02:00
Klaas van Schelven
2011006e74
Remove 'TODO' that was apparently already acted on
2024-04-05 11:13:08 +02:00
