mirror/cypress
1
0
Fork 0
mirror of https://github.com/cypress-io/cypress.git synced 2026-01-25 08:29:06 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix: Backing out driver change for type (#20155)

Browse Source 
* fix: Backing out driver change for type

* Adding comment for posterity

* Fixing test
This commit is contained in:
Tyler Biethman
2022-02-11 14:44:43 -06:00
committed by GitHub
parent 9cad97a3c8
commit 22c1683f3c
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/app/src/runner/SpecRunnerHeader.cy.tsx
View File

@@ -137,7 +137,7 @@ describe('SpecRunnerHeader', { viewportHeight: 500 }, () => {
cy.findByRole('list').within(() =>
['Chrome', 'Electron', 'Firefox'].forEach((browser) => cy.findAllByText(browser)))
cy.get('[data-cy="select-browser"] button[aria-controls]').focus().type(' ')
cy.get('[data-cy="select-browser"] button[aria-controls]').focus().type('{enter}')
cy.contains('Firefox').should('be.hidden')
})
@@ -152,7 +152,9 @@ describe('SpecRunnerHeader', { viewportHeight: 500 }, () => {
cy.contains('The viewport determines').should('be.visible')
cy.get('[data-cy="viewport"]').click()
cy.contains('The viewport determines').should('be.hidden')
cy.get('[data-cy="viewport"] button').focus().type(' ')
// TODO: enable/remove with resolution of https://github.com/cypress-io/cypress/pull/20156
// cy.get('[data-cy="viewport"] button').focus().type(' ')
cy.get('[data-cy="viewport"] button').focus().type('{enter}')
cy.contains('The viewport determines').should('be.visible')
cy.get('[data-cy="viewport"] button').focus().type('{enter}')
cy.contains('The viewport determines').should('be.hidden')

4
packages/driver/src/cy/commands/actions/type.ts
View File

@@ -342,9 +342,7 @@ export default function (Commands, Cypress, cy, state, config) {
// event.target is null when used with shadow DOM.
(event.target && $elements.isButtonLike(event.target)) &&
// When a space key is pressed for input radio elements, the click event is only fired when it's not checked.
!(event.target.tagName === 'INPUT' && event.target.type === 'radio' && event.target.checked === true) &&
// Click event should not be emitted if defaultPrevented
!event.defaultPrevented
!(event.target.tagName === 'INPUT' && event.target.type === 'radio' && event.target.checked === true)
) {
fireClickEvent(event.target)
}