mirror/cypress
1
0
Fork 0
mirror of https://github.com/cypress-io/cypress.git synced 2026-02-14 03:00:21 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #519 from cypress-io/issue-573

Browse Source 
driver: fix latest version of chrome disabling embedded credential'd resources
This commit is contained in:
Brian Mann
2017-09-28 10:23:13 -04:00
committed by GitHub
parent a8bf485f35 ab3d155aa8
commit 27ba2e8816
4 changed files with 20 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/driver/package.json
View File

@@ -22,6 +22,7 @@
"@cypress/underscore.inflection": "^1.0.0",
"angular": "^1.3.1",
"backbone": "^1.3.3",
"basic-auth": "^2.0.0",
"blob-util": "^1.2.1",
"bluebird": "3.5.0",
"body-parser": "^1.12.4",

7
packages/driver/test/cypress/integration/issues/573_spec.coffee
View File

@@ -1,3 +1,4 @@
describe.skip "basic auth", ->
it "prompts", ->
cy.visit("http://admin:admin@the-internet.herokuapp.com/basic_auth")
describe "basic auth", ->
it "can visit", ->
cy.visit("http://cypress:password123@localhost:3500/basic_auth")
# cy.visit("http://admin:admin@the-internet.herokuapp.com/basic_auth")

11
packages/driver/test/support/server.coffee
View File

@@ -1,5 +1,6 @@
_ = require("lodash")
fs = require("fs")
auth = require("basic-auth")
bodyParser = require("body-parser")
express = require("express")
http = require("http")
@@ -62,6 +63,16 @@ app.get "/buffer", (req, res) ->
res.type("pdf")
res.send(bytes)
app.get "/basic_auth", (req, res) ->
user = auth(req)
if user and (user.name is "cypress" and user.pass is "password123")
res.send("<html><body>basic auth worked</body></html>")
else
res
.set("WWW-Authenticate", "Basic")
.sendStatus(401)
app.use(express.static(path.join(__dirname, "..", "cypress")))
app.use(require("errorhandler")())

4
packages/server/lib/browsers/chrome.coffee
View File

@@ -36,6 +36,10 @@ defaultArgs = [
"--enable-automation"
"--disable-infobars"
## needed for https://github.com/cypress-io/cypress/issues/573
## list of flags here: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/runtime_enabled_features.json5
"--disable-blink-features=BlockCredentialedSubresources"
## the following come frome chromedriver
## https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/chromedriver/chrome_launcher.cc&sq=package:chromium&l=70
"--metrics-recording-only"