chore: change path created in prevous PR to make windows compliant (#29551)

empty commit to run ci [run ci]

squash this
This commit is contained in:
Bill Glesias
2024-05-21 14:35:43 -04:00
committed by GitHub
parent 2567b72a5a
commit 374ceb20f9
4 changed files with 19 additions and 3 deletions

View File

@@ -76,7 +76,7 @@ windowsWorkflowFilters: &windows-workflow-filters
- equal: [ develop, << pipeline.git.branch >> ]
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
- equal: [ 'feat/vite_5_support', << pipeline.git.branch >> ]
- equal: [ 'chore/fix_illegal_characters_in_windows', << pipeline.git.branch >> ]
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>

View File

@@ -3964,8 +3964,24 @@ describe('Routes', () => {
})
})
/**
* NOTE: certain characters cannot be used inside our own monorepo due to our system tests also needing to run
* inside Windows. The following are reserved characters:
*
* < (less than)
* > (greater than)
* : (colon)
* " (double quote)
* / (forward slash)
* \ (backslash)
* | (vertical bar or pipe)
* ? (question mark)
* * (asterisk)
*
* @see https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#naming-conventions for more details
*/
it('can serve files with special characters in the fileServerFolder path', async function () {
await this.setupProject({ fileServerFolder: `dev/_ :;.,"'!(){}[]@<>=-+*$&\`|~^ĵ符` })
await this.setupProject({ fileServerFolder: `dev/_ ;.,'!(){}[]@=-+$&\`~^ĵ符` })
return this.rp({
url: `${this.proxy}/foo.txt`,
@@ -3975,7 +3991,7 @@ describe('Routes', () => {
})
.then((res) => {
expect(res.statusCode).to.eq(200)
expect(res.headers).to.have.property('x-cypress-file-path', encodeURI(`${Fixtures.projectPath('no-server')}/dev/_ :;.,"'!(){}[]@<>=-+*$&\`|~^ĵ符/foo.txt`))
expect(res.headers).to.have.property('x-cypress-file-path', encodeURI(`${Fixtures.projectPath('no-server')}/dev/_ ;.,'!(){}[]@=-+$&\`~^ĵ符/foo.txt`))
expect(res.body).to.eq('foo')
})
})