mirror/cypress
1
0
Fork 0
mirror of https://github.com/cypress-io/cypress.git synced 2026-02-21 14:41:00 -06:00
Code Issues Packages Projects Releases Wiki Activity

chore: Update querying of element to not chain actions/assertions so many levels to address test flake (#28878)

Browse Source 
* Update querying of element to account for our best practice recommendations

* Remove selectBrowser check on not being visible here.
This commit is contained in:
Jennifer Shehane
2024-02-08 11:19:19 -05:00
committed by GitHub
parent 90da806a06
commit aacf0a3e29
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/app/cypress/e2e/cypress-in-cypress.cy.ts
View File

@@ -198,10 +198,8 @@ describe('Cypress in Cypress', { viewportWidth: 1500, defaultCommandTimeout: 100
cy.get('[data-cy="select-browser"]').as('selectBrowser')
cy.viewport(500, 600)
cy.get('@selectBrowser')
.should('not.be.visible')
.scrollIntoView()
.should('be.visible') // with no specs list open, we should see this by scrolling
cy.get('@selectBrowser').scrollIntoView()
cy.get('@selectBrowser').should('be.visible') // with no specs list open, we should see this by scrolling
dragHandleToClientX('panel2', 200).then(() => {
cy.contains('Chrome 1').should('be.visible')
@@ -210,10 +208,9 @@ describe('Cypress in Cypress', { viewportWidth: 1500, defaultCommandTimeout: 100
cy.contains('[aria-controls=reporter-inline-specs-list]', 'Specs')
.click({ force: true })
cy.get('@selectBrowser')
.should('not.be.visible')
.scrollIntoView()
.should('not.be.visible') // with specs list open, scrolling is not enough to see this
cy.get('@selectBrowser').should('not.be.visible')
cy.get('@selectBrowser').scrollIntoView()
cy.get('@selectBrowser').should('not.be.visible') // with specs list open, scrolling is not enough to see this
dragHandleToClientX('panel1', 130)
cy.get('@selectBrowser')